Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy package-lock.json too #131

Open
j-frost opened this issue Oct 30, 2023 · 2 comments
Open

Copy package-lock.json too #131

j-frost opened this issue Oct 30, 2023 · 2 comments

Comments

@j-frost
Copy link

j-frost commented Oct 30, 2023 •
edited
Loading

Currently, AppEngine complains during upload:

Updating service [default]...⠶WARNING: *** Improve build performance by generating and committing package-lock.json.

If this is not some kind of config error on my part, I'll be happy to submit a PR for this.
@HalfdanJ
Copy link
Owner

HalfdanJ commented Jan 1, 2024

It's not on your part. It is a warning, but i've been ignoring it since I don't think it actually has any meaningful impact in this case, since very few dependencies are actually installed in appengine.

@novakma2
Copy link

It seems to be good practice probably, gets rid of warning and does no harm probably 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HalfdanJ @j-frost @novakma2