Websocket regression in 0.9.98

[themadsens]

My websocket integration with Amplex GridLight broke in 0.9.98

Immediately after opening the url: wss://demo.gridlight.dk/changes

I get a callback with type="fail", message=nil

with 0.9.97 I get (as expected) type="open", message=nil and then type="received", message="authenticate"

[cmsj]

Thanks for the report. I upgraded the websocket library we use, which may be related. Is there a simple snippet I can use to reproduce what you're seeing? (Or would that need authentication?)

[themadsens]

Thank for noticing :-). No, the following snippet should be enough to reproduce the above behaviour:
The server is online, and the error actually prevents the "authenticate" step. It does not even get to saying "open"

  local wsUrl = "wss://demo.gridlight.dk/changes"
  print("WS open", wsUrl)
  ws = hs.websocket.new(wsUrl, function(typ, msg) 
      print("WS:", typ, msg)
  end)

[cmsj]

ws = hs.websocket.new("wss://demo.gridlight.dk/changes", function(state, message) print(state) print(message) end)

appears to be sufficient to reproduce what you're seeing.

[cmsj]

Hah, I hadn't refreshed this tab in the last hour, so I missed you had also posted a reproducer. Thanks! I'll take a look and see if I can figure out what's going wrong.

[cmsj]

Yeah this is definitely broken. Looks like it might be an issue in SocketRocket (the underlying library we're using for websockets), which, worryingly, hasn't been updated since 2021. I'll revert to the earlier version of the library (PR is up already, #3424 ) and get a new Hammerspoon release out. Thanks again!

[Moulick]

Homebrew/homebrew-cask#142987

[latenitefilms]

I wonder if this change has anything to do with it?

5271943

[cmsj]

@latenitefilms I don't think so, that was just the underlying library separating out one method into two, but I dunno, better to revert quickly and take our time in figuring out a way forward (which may involve moving away from SocketRocket entirely - NSURLSession supports websockets in our minimum macOS version)