Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need to explicitly make injectables async compatible #20

Open
HampusMat opened this issue Sep 27, 2023 · 0 comments
Open

Remove need to explicitly make injectables async compatible #20

HampusMat opened this issue Sep 27, 2023 · 0 comments
Labels
feature A feature request help wanted Extra attention is needed

Comments

@HampusMat
Copy link
Owner

HampusMat commented Sep 27, 2023 •
edited
Loading

The need to explicitly make injectables async compatible should be removed.

This would be simple if not for the fact that having the async crate feature enable this by default would make it have a non-additive change. More about that here.

An alternative approach to this would be to only implement AsyncInjectable when the type, dependencies and interface are Send + Sync + 'static. This however is not possible (as far as i know) as long as trivial constraints is not stabilized. And even if it becomes stabilized, using it would break the 1.62.1 MSRV.

More research needs to be done about this
@HampusMat HampusMat added help wanted Extra attention is needed feature A feature request labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A feature request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HampusMat