Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug when generating plantuml URL on windows platform #1

Closed
HansBug opened this issue Nov 30, 2020 · 1 comment
Closed

A bug when generating plantuml URL on windows platform #1

HansBug opened this issue Nov 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@HansBug
Copy link
Owner

HansBug commented Nov 30, 2020

A bug when generating plantuml URL on windows platform

This is caused by the difference of the implements of os.path.join on Linux and windows.

from plantumlcli import RemotePlantuml

if __name__ == "__main__":
    r = RemotePlantuml.autoload()
    print(r._RemotePlantuml__request_url(os.path.join('123', 'sdkfjl')))

It will print http://www.plantuml.com/plantuml/123%5Csdkfjl on windows, while this is a wrong url.

@HansBug HansBug added the bug Something isn't working label Nov 30, 2020
@HansBug
Copy link
Owner Author

HansBug commented Nov 30, 2020

Fixed in v0.0.2 👍

@HansBug HansBug closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant