chore!: remove launch configuration #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kayman-mk! 👋 Thank you for your contribution to the project. Please refer to the Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it This message was generated automatically. You are welcome to |
|
Tested with spot and on-demand instances. |
kindermannlennart
approved these changes
Jan 31, 2025
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
aws_launch_configurationis deprecated and replaced byaws_launch_template. This PR replaces the deprecated resources and combines the on-demand and spot settings into one launch template.Fixes #383
Migrations required
Depending on the AMI used, you have to set the
var.instance.root_device_name. We use/dev/xvdaas default, which should work for Linux instances.