Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The preview in the voice tab is broken in the audio editor #3135

Closed
LuigiXHero opened this issue Aug 21, 2023 · 1 comment · Fixed by #3142
Closed

The preview in the voice tab is broken in the audio editor #3135

LuigiXHero opened this issue Aug 21, 2023 · 1 comment · Fixed by #3142

Comments

@LuigiXHero
Copy link
Contributor

Was fine in my PR, but either broke because of formatting or some other change in develope I didn't notice.

Will look into it when I can, and I'll check the sfx tab also.
@LuigiXHero
Copy link
Contributor Author

LuigiXHero commented Aug 22, 2023 •
edited
Loading

Let's say you switch Navi - Hello! to Talon - Scream. Then you change Adult Link - Big Slash to Navi - Hello!
Navi! - Hello will properly be Talon - Scream in the preview but Adult Link - Big Slash will also be Talon - Scream in the preview
So it seems it's pulling the preview sound based on what's selected and not what the original sound is.
This is only for the voice tab, the sfx tab is fine it seems.

@LuigiXHero LuigiXHero mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the preview in voice tab LuigiXHero/Shipwright
1 participant
@LuigiXHero