[V3?] Random crash when generating seeds, seemingly caused by concurrency issue in CVar handling.

[Pepper0ni]

The crash (signal SIGSEGV: address not mapped to object (fault address: 0x55500e01d860)) happens to me on linux quite often in the latest version, and more rarely to other people.

The exact cvar that it crashes on is inconsistent, but does not occur in the main randomiser thread. However every crash I have checked has the main randomiser thread in the middle of CVarLoad on line 22 of rando-main.cpp.

My theory is that a lock on the cvar table is not being enforced properly.

Stack trace for the crash:

std::__detail::_Hashtable_base<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Hashtable_traits<true, false, true>>::_M_equals(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, unsigned long, std::__detail::_Hash_node_value<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true> const&) const (/usr/include/c++/14.2.1/bits/hashtable_policy.h:1759)
std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::_M_find_before_node(unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, unsigned long) const (/usr/include/c++/14.2.1/bits/hashtable.h:2074)
std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::_M_find_node(unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, unsigned long) const (/usr/include/c++/14.2.1/bits/hashtable.h:822)
std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::find(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) (/usr/include/c++/14.2.1/bits/hashtable.h:1738)
std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::shared_ptr<Ship::CVar>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>>::find(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) (/usr/include/c++/14.2.1/bits/unordered_map.h:877)
Ship::ConsoleVariable::Get(char const*) (/home/pepper0ni/github/ShipwrightFork/libultraship/src/config/ConsoleVariable.cpp:20)
Ship::ConsoleVariable::GetInteger(char const*, int) (/home/pepper0ni/github/ShipwrightFork/libultraship/src/config/ConsoleVariable.cpp:25)
::CVarGetInteger(const char *, int32_t) (/home/pepper0ni/github/ShipwrightFork/libultraship/src/public/bridge/consolevariablebridge.cpp:10)
Rando::Option::RenderCheckbox() const (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/option.cpp:200)
Rando::Option::RenderImGui() const (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/option.cpp:141)
Rando::OptionGroup::RenderImGui() const (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/option.cpp:473)
Rando::OptionGroup::RenderImGui() const (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/option.cpp:460)
RandomizerSettingsWindow::DrawElement() (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/randomizer.cpp:1902)
Ship::GuiElement::Draw() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/window/gui/GuiElement.cpp:40)
Ship::Gui::DrawMenu() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/window/gui/Gui.cpp:377)
gfx_start_frame() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/graphic/Fast3D/gfx_pc.cpp:3964)
Fast::Fast3dWindow::StartFrame() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/graphic/Fast3D/Fast3dWindow.cpp:144)
::Graph_StartFrame() (/home/pepper0ni/github/ShipwrightFork/soh/soh/OTRGlobals.cpp:1363)
RunFrame (/home/pepper0ni/github/ShipwrightFork/soh/src/code/graph.c:514)

Stack trace for main rando thread:

std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (/usr/include/c++/14.2.1/bits/shared_ptr_base.h:1069)
std::__shared_ptr<Ship::CVar, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (/usr/include/c++/14.2.1/bits/shared_ptr_base.h:1525)
std::shared_ptr<Ship::CVar>::~shared_ptr() (/usr/include/c++/14.2.1/bits/shared_ptr.h:175)
std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>::~pair() (/usr/include/c++/14.2.1/bits/stl_pair.h:284)
void std::destroy_at<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>*) (/usr/include/c++/14.2.1/bits/stl_construct.h:88)
void std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>>>::destroy<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>(std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>>&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>*) (/usr/include/c++/14.2.1/bits/alloc_traits.h:556)
std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>>>::_M_deallocate_node(std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>*) (/usr/include/c++/14.2.1/bits/hashtable_policy.h:2040)
std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>>>::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, true>*) (/usr/include/c++/14.2.1/bits/hashtable_policy.h:2062)
std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::clear() (/usr/include/c++/14.2.1/bits/hashtable.h:2584)
std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::shared_ptr<Ship::CVar>, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const, std::shared_ptr<Ship::CVar>>>>::clear() (/usr/include/c++/14.2.1/bits/unordered_map.h:799)
Ship::ConsoleVariable::Load() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/config/ConsoleVariable.cpp:270)
::CVarLoad() (/home/pepper0ni/github/ShipwrightFork/libultraship/src/public/bridge/consolevariablebridge.cpp:82)
RandoMain::GenerateRando(std::set<RandomizerCheck, std::less<RandomizerCheck>, std::allocator<RandomizerCheck>>, std::set<RandomizerTrick, std::less<RandomizerTrick>, std::allocator<RandomizerTrick>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>) (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/3drando/rando_main.cpp:22)
GenerateRandomizerImgui(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>) (/home/pepper0ni/github/ShipwrightFork/soh/soh/Enhancements/randomizer/randomizer.cpp:1787)
void std::__invoke_impl<void, void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(std::__invoke_other, void (*&&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&&) (/usr/include/c++/14.2.1/bits/invoke.h:61)
std::__invoke_result<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>::type std::__invoke<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>(void (*&&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&&) (/usr/include/c++/14.2.1/bits/invoke.h:96)
void std::thread::_Invoker<std::tuple<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (/usr/include/c++/14.2.1/bits/std_thread.h:301)
std::thread::_Invoker<std::tuple<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>>::operator()() (/usr/include/c++/14.2.1/bits/std_thread.h:308)
std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>), std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>>>::_M_run() (/usr/include/c++/14.2.1/bits/std_thread.h:253)
execute_native_thread_routine (@execute_native_thread_routine:11)
___lldb_unnamed_symbol3666 (@___lldb_unnamed_symbol3666:202)
___lldb_unnamed_symbol4097 (@___lldb_unnamed_symbol4097:6)```

[Pepper0ni]

fixed in #4318