Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] put away sword immediately #555

Closed
nr1995 opened this issue Jun 26, 2022 · 3 comments
Closed

[Feature Request] put away sword immediately #555

nr1995 opened this issue Jun 26, 2022 · 3 comments

Comments

@nr1995
Copy link

nr1995 commented Jun 26, 2022

In Twilight Princess
you can put away your sword if you take your thumb off the analog stick for even a millisecond.

Something that's annoyed me for over 20 years is that in Ocarina of Time
you have to awkwardly stand there doing absolutely nothing for ~2 seconds
before you're allowed to, for no apparent reason.

An option to change this would be much appreciated, by me at least :)
Thanks!

@vaguerant
Copy link
Contributor

vaguerant commented Jun 27, 2022

Should be very doable, this looks to be where the magic is (or isn't) happening:

if (doAction != DO_ACTION_PUTAWAY) {
this->unk_837 = 20;
}
else if (this->unk_837 != 0) {
doAction = DO_ACTION_NONE;
this->unk_837--;
}

That 20 is a timer for how long to wait before switching to "Put Away". #507 is sorting enhancements like this into their own "Time Savers" section in the UI. There seems to be growing concern among developers about feature creep in enhancements and overburdening users with choices. I think this feature might get lost in the crowd currently, but maybe it could be revisited once #507 is merged so it can be added as a Time Saver feature?

@Kenix3
Copy link
Collaborator

Kenix3 commented Jul 12, 2022

#600

@aMannus
Copy link
Contributor

aMannus commented Jul 26, 2022

Resolved by #600

@aMannus aMannus closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants