Anti-Aliasing will not function until the graphics tab is selected

[andrewwvc]

When starting up the game, even if AA is already set, it will not be applied to the game's graphics for that session until the graphics tab in the F1 menu has at least been hovered over.

Tested using develop-rachael, running on Pop!_OS 22.04 with default compiler settings.

[Flax4]

Can confirm this happens on Windows too.

[andrewwvc]

Ok, I've found the cause and believe I may have a solution. The lines in ImGuiImpl.cpp:
gfx_current_dimensions.internal_mul = CVar_GetFloat("gInternalResolution", 1);
gfx_msaa_level = CVar_GetS32("gMSAAValue", 1);

are each only called in the block that begins with:
if (ImGui::BeginMenu("Graphics"))

and these variables are otherwise never changed by the game code.
By adding these lines to the Init section of code in ImGuiImpl.cpp (immediately after ImGuiBackendInit() is called) the AA and resolution scaling will be applied at startup.

If there's a more appropriate section of the codebase to put this change instead, I'd be happy to know.

[GaryOderNichts]

Initializing gfx_current_dimensions.internal_mul in SohImGui::Init will end up overwriting the multiplier in gfx_init:

Shipwright/libultraship/libultraship/Lib/Fast3D/gfx_pc.cpp

Line 2652 in d4c1c40

gfx_current_dimensions.internal_mul = 1;

Either remove that line or move the initialization to gfx_init.

[andrewwvc]

Either remove that line or move the initialization to gfx_init.

So, to be clear, are you arguing that the other line setting internal_mul to 1 ought to be replaced with CVar_GetS32("gMSAAValue", 1) given the CVars would default to 1 anyway, in which case gfx_msaa_level should be in the same gfx_init function? If so, I'll just make that change.

[GaryOderNichts]

So, to be clear, are you arguing that the other line setting internal_mul to 1 ought to be replaced with CVar_GetS32("gMSAAValue", 1) given the CVars would default to 1 anyway, in which case gfx_msaa_level should be in the same gfx_init function? If so, I'll just make that change.

That's what I meant. Thanks for making a PR.