Add window to customize specific controls #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only for the ocarina
|
Have not forgotten this PR. It’s been a busy weekend but want to look this over soon 🙂 |
Kenix3
approved these changes
Aug 15, 2022
dcvz
approved these changes
Aug 16, 2022
dcvz
added a commit
to dcvz/Shipwright
that referenced
this pull request
Aug 16, 2022
This reverts commit 46a421f.
louist103
pushed a commit
to louist103/Shipwright-1
that referenced
this pull request
Aug 19, 2022
Kenix3
pushed a commit
to Kenix3/Shipwright
that referenced
this pull request
Oct 19, 2022
dcvz
pushed a commit
to briaguya-ai/Shipwright
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the merge issues from #851 but otherwise makes the same changes.
This adds a window accessed from the Enhancements > Controls menu that contains options to change the way certain actions are mapped to the N64 controller, sorted using collapsing headers like the cosmetics menu. Some or all of the controls enhancements could be moved into this window, but that's outside the scope of this PR.
As for the ocarina control panel, there are options to change which play which notes as well as which buttons modify the note (originally L, R, and Z). Additionally, the option to use the D-pad for the ocarina and text was split with the latter being moved to the ocarina controls, and there's a new option to play the ocarina using the camera stick.