ADD: Enhancement presets

[aMannus]

Adds the ability to change all enhancements in one go based on predetermined presets. Attempt at making the option bloat a little more managable.

I'd like some input on a better place to put applyEnhancementPresets() in though. I wasn't sure what would be best so for now, it lives inside the ImGuilmpl.cpp file, but this should probably be moved somewhere else.

Also, there's no linebreaks for the tooltip yet because of #925

I think the presets I defined make sense, but obviously open for discussion for those too.

Looks like this: https://cdn.discordapp.com/attachments/989182407213219840/1001046928697589810/2022-07-25_10-41-00.mp4

[jbodner09]

If some of the preset options are strict supersets of other options, it might make sense to just have separate functions to set those presets. That way, you can just call those functions in whatever cases you need, including future ones that would make this more reusable without the potential to miss something. It also makes this more readable since looking at each case would tell you exactly what's unique to it instead of having to figure out "oh, Text Speed being set to 5 is in all the cases except vanilla; that must be part of the Vanilla Plus/Quality of life stuff".

[aMannus]

If some of the preset options are strict supersets of other options, it might make sense to just have separate functions to set those presets. That way, you can just call those functions in whatever cases you need, including future ones that would make this more reusable without the potential to miss something. It also makes this more readable since looking at each case would tell you exactly what's unique to it instead of having to figure out "oh, Text Speed being set to 5 is in all the cases except vanilla; that must be part of the Vanilla Plus/Quality of life stuff".

That's a good idea. I'll seperate all presets in their own function.

[BlakeStinson]

Up to you if you want to change this, but I added in the latest Zhora build a 17th option to gPauseLiveLink that makes Link's animations cycle like it does when the game isn't paused.

[aMannus]

I've changed the rando preset to the newest one now. I think for the other presets, the standing link still fits the best. If people want to go change it afterwards, they'll still have the ability to dive into the menus.

[aMannus]

I moved the functions for handling the presets from ImGuilmp.cpp to their own files now. Also gave every preset their own function, and they now apply settings in a cascading manner. It does call CVar_SetS32() a few more times compared to the old method, but overall this is a MUCH cleaner implementation.

As far as I can tell, it's fully ready for review now.

[aMannus]

Had to move the functions back into ImGuilmpl.cpp. libultra can't load files from soh, and the menu creation part in that file is going to move into soh soon, so I don't feel too bad for having a big codeblock in that file for now. But yeah, this'll need cleaning up when that switch happens.

Rest still works the same and Jenkins is finally happy.

[andrewwvc]

What this is doing overall is good. Letting people create custom settings presets so that people can mod in game modes would be a nice way of doing things going forward, as expecting each player to fiddle around with all the individual settings for everything is becoming too involved.

I do want to put out a word of caution when programmatically changing settings though, as there have been issues stemming from certain settings only being applied when the GUI menu in which they are defined is actually accessed. Is there a way of putting in code hooks to account for that?

[aMannus]

I do want to put out a word of caution when programmatically changing settings though, as there have been issues stemming from certain settings only being applied when the GUI menu in which they are defined is actually accessed. Is there a way of putting in code hooks to account for that?

Enhancements shouldn't ever only be applied when the specific tab is open though. If that is ever happening, that should be fixed within the enhancement itself. All the presets do is set the CVars, it doesn't care about where the CVar is normally set or what it was before. It's comparable to how SoH loads in CVars from shipofharkinian.json when you open the game.

[Kenix3]

A few comments for discussion.

• I prefer the term "Authentic" to "Vanilla."
• I'm not sold on the iron man preset.

Right now, this is just a point of discussion, but I'd like to hide a lot of menu items when a preset is in use.

[vaguerant]

Along the lines of both andrewwvc and Kenix's comments, if you made presets "mandatory" and the presets were themselves editable, you could actually remove the entire Enhancements menu except for the presets and the option to edit them, so that managing your enhancements is done entirely by editing the presets to match your goals (probably in a new Manage Presets window).

In that window, I'd suggest something like a drop-down (combobox) to select which preset you'd like to edit (defaulted to the current preset) then a tabbed interface that incorporates all of the current Enhancements menu, split into the major groups (Gameplay, Graphics, etc.).

[aMannus]

A few comments for discussion.

• I prefer the term "Authentic" to "Vanilla."
• I'm not sold on the iron man preset.

Right now, this is just a point of discussion, but I'd like to hide a lot of menu items when a preset is in use.

The only time the name "Vanilla" is used in the "Vanilla Plus" preset. Otherwise it's called "Default" right now. I don't think "Authentic Plus" is a very good name. "Default" could be renamed to "Authentic", but I think the name "Default" makes it a lot more clear about what it does.

And I honestly just threw in the Ironman preset for fun. I'd be totally OK removing it outright.

[aMannus]

As for the discussion about hiding options and/or editing presets, I personally don't like hiding only certain options based on what presets are applied. Having an entire window to edit presets also feels like overcomplicating things for both the code side and UX.

What I'd personally think is a better idea is having the dropdown immediately apply the presets, hide all the enhancements when any of the presets are selected, and then having another entry in the dropdown called "Custom". If "Custom" is selected, then all enhancements are shown and people can change whatever they want in it, and it'll save the enhancements for that preset even when switching back and forth to other presets.

There's one drawback to doing it this way (or any other way where you hide enhancements). It's very opaque to a user what enhancements are applied with whatever preset, which I'm not a big fan of.

As a future thing, saving/loading that custom preset would also be nice. I'm not sure the best way to do this would be, but this would allow people to have a collection of their own presets they can import whenever they want, and possibly share their presets with others as well.

I'm not entirely sure if any of this should be in the scope of this PR though or something that can be worked on for the future. Might also need to wait until the ImGui LUS cleanup is done before making huge changes to how this works.

[aMannus]

Just spitballing for the future, but maybe it's a good idea to have all the presets in seperate JSON files living in a folder, with a list of "cvarname : false/true". It would then always apply the default preset to zero it out and then whatever preset is defined in the relevant other JSON file in a cascading fashion (kinda like how it's being done right now too). Building on my previous comment, the JSON file for the "Custom" preset would then be automatically updated whenever an option is toggled.

That way the JSON file for the "custom" preset could be backed up/shared easily, and people can edit/look at the other presets if they desire to do so.

Again though, this would definitely be a post LUS cleanup thing.