Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed result as previous version 0.4.4 #26

Closed
trapcodeio opened this issue Nov 13, 2021 · 3 comments · Fixed by #27
Closed

Compressed result as previous version 0.4.4 #26

trapcodeio opened this issue Nov 13, 2021 · 3 comments · Fixed by #27
Assignees

Comments

@trapcodeio
Copy link
Contributor

First, I would like to say: Thank you for this awesome library. 😁

After upgrading from 0.4.4 to 0.6.1 i noticed the rendered result has changed.
The old version renders a more compressed HTML than the new.
Is there an option to return compressed results?

These are links to runkit tests...

NEW: https://runkit.com/embed/ihmlwatb26ta
OLD: https://runkit.com/embed/0lti2qtil2vb

Images of results

NEW:

Screenshot 2021-11-13 at 8 32 32 PM

OLD:

Screenshot 2021-11-13 at 8 33 24 PM

@Hargne
Copy link
Owner

Hargne commented Nov 15, 2021

Hi,
Yes, as of 0.6.0 the package formats the HTML using the Prettier standard.
There are currently no option to disable the formatting, however I suppose it should be possible to add one.

@Hargne Hargne self-assigned this Nov 15, 2021
@trapcodeio
Copy link
Contributor Author

trapcodeio commented Nov 19, 2021

Okay, Should I be expecting any update or fix soon?
If you are busy I could assist by creating a pull request for it.

It would be needed in cases where speed is a consign.

@Hargne
Copy link
Owner

Hargne commented Nov 19, 2021

I am working on it :)

@Hargne Hargne mentioned this issue Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants