Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on android #3

Closed
stephenkopylov opened this issue Jun 20, 2018 · 4 comments
Closed

Crash on android #3

stephenkopylov opened this issue Jun 20, 2018 · 4 comments

Comments

@stephenkopylov
Copy link

stephenkopylov commented Jun 20, 2018

Hi buddy and thanks a lot for this amazing library!

Could you please take a look on this issue?
naoufal/react-native-touch-id#65

I'm using your package and face this crash with android 5.

You can easily reproduce it with android emulator and 22'th API

Is it possible to avoid using Fingerprint on old android devices using this method:
naoufal/react-native-touch-id#65 (comment)
?

@jeremy-farnault
Copy link
Contributor

Hi!

I updated the react-native-touch-id version using the commit fixing this issue.
It's working on my simulator.
Thanks for letting me know.

Cheers.

@stephenkopylov
Copy link
Author

stephenkopylov commented Jun 21, 2018

@Haskkor Thanks!

But we have another problem - when I'm trying to install it using yarn I'm getting this error:

yarn add @haskkor/react-native-pincode

yarn add v1.6.0

[1/4] 🔍  Resolving packages...
error Couldn't find match for "12ec9daf5cbd4fe507ed20a1284efb52dcf45c13" in "refs/heads/fix/81-90,refs/heads/master,refs/pull/1/head,refs/pull/10/head,refs/pull/10/merge,refs/pull/100/head,refs/pull/101/head,refs/pull/101/merge,refs/pull/102/head,refs/pull/102/merge,refs/pull/103/head,refs/pull/104/head,refs/pull/109/head,refs/pull/11/head,refs/pull/115/head,refs/pull/115/merge,refs/pull/118/head,refs/pull/118/merge,refs/pull/120/head,refs/pull/120/merge,refs/pull/122/head,refs/pull/123/head,refs/pull/123/merge,refs/pull/129/head,refs/pull/13/head,refs/pull/15/head,refs/pull/16/head,refs/pull/17/head,refs/pull/17/merge,refs/pull/20/head,refs/pull/21/head,refs/pull/25/head,refs/pull/25/merge,refs/pull/26/head,refs/pull/27/head,refs/pull/27/merge,refs/pull/3/head,refs/pull/30/head,refs/pull/30/merge,refs/pull/31/head,refs/pull/31/merge,refs/pull/32/head,refs/pull/35/head,refs/pull/35/merge,refs/pull/4/head,refs/pull/4/merge,refs/pull/40/head,refs/pull/40/merge,refs/pull/41/head,refs/pull/41/merge,refs/pull/42/head,refs/pull/42/merge,refs/pull/45/head,refs/pull/45/merge,refs/pull/5/head,refs/pull/53/head,refs/pull/54/head,refs/pull/54/merge,refs/pull/55/head,refs/pull/58/head,refs/pull/6/head,refs/pull/69/head,refs/pull/69/merge,refs/pull/70/head,refs/pull/72/head,refs/pull/73/head,refs/pull/73/merge,refs/pull/75/head,refs/pull/78/head,refs/pull/78/merge,refs/pull/80/head,refs/pull/81/head,refs/pull/81/merge,refs/pull/88/head,refs/pull/88/merge,refs/pull/90/head,refs/pull/90/merge,refs/pull/91/head,refs/pull/91/merge,refs/pull/92/head,refs/pull/96/head,refs/pull/96/merge,refs/pull/99/head,refs/pull/99/merge,refs/tags/v0.1.1,refs/tags/v1.0.0,refs/tags/v1.0.1,refs/tags/v1.1.0,refs/tags/v1.1.1,refs/tags/v1.2.1,refs/tags/v2.0.0,refs/tags/v2.0.2,refs/tags/v2.0.3,refs/tags/v2.0.4,refs/tags/v3.0.0,refs/tags/v3.1.0,refs/tags/v4.0.0,refs/tags/v4.0.1" for "https://github.com/naoufal/react-native-touch-id.git".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.`

As I understand, something is wrong with usage of commit "12ec9daf5cbd4fe507ed20a1284efb52dcf45c13"

UPD:
Even when I do it this way

yarn add https://github.com/naoufal/react-native-touch-id.git#12ec9daf5cbd4fe507ed20a1284efb52dcf45c13

I get the same error...

@Antlitz
Copy link

Antlitz commented Jun 21, 2018

got the same error with yarn, install work only with npm + million manipulations :))

@jeremy-farnault
Copy link
Contributor

I forgot to clean my cache before testing yesterday...sorry :).

I made a new version using the commit fix made by gazaret on naoufal/react-native-touch-id#96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants