-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More explicit svgo version #99
Comments
@waldyrious That's a good point. But doesn't the "or newer" part kind of undermine what you are suggesting? |
Yes, I agree that the previous wording was too vague too. That's why I suggested a version range. However, that could be a little awkward to track manually; perhaps we should add Alternatively, as a simpler method, we could simply mention the specific version that has been manually tested to work, and using anything else would be at the responsibility of the contributor. |
I'm afraid I'm not all that familiar with Node.js, package.json, devDependencies, CI, etc. If we want to keep things simple, how about including something like this in the README under the Contributing section?
|
Yeah, that sounds good! To be honest the automated CI setup would be a bit of overengineering considering that we can get like 90% of the benefit with 10% of the effort by following your suggestion :) I would perhaps not recommend installing - svgo ./flags --recursive --config=svgo.config.js to: + node_modules/svgo/bin/svgo ./flags --recursive --config=svgo.config.js So we might as well declare the dependency in |
Moving a discussion started in c9eed38 into an actual issue, to make it more trackable :) Repeating what I said there:
@HatScripts I think it's better to mention a specific version or version range that's been tested to work, in case they introduce breaking changes that invalidate this statement. E.g. #93.
@HatScripts, would you mind copying your response below, so it gets properly attributed to you? Then we can continue the discussion here.
The text was updated successfully, but these errors were encountered: