You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NETWORKSETTINGS_* actions are not conveying the best meaning, as stated in this commit 095510f and this comment on PR(10)#350. Here is a proposal to change it:
Actions
NETWORKSETTINGS_UPDATE_REQUEST: an action triggered by user to update the network settings submitted through the form
NETWORKSETTINGS_PERSIST_STORE: an action triggered by an update effect demanding that the network settings produced by it be persisted in the app storage
NETWORKSETTINGS_UPDATE_STATE: an action triggered by init effect to update the Redux state with the custom network settings stored
NETWORKSETTINGS_UPDATE_WAITING: an action triggered by persist effect to indicate that the persistence is complete and the wallet needs to be reloaded
NETWORKSETTINGS_UPDATE_SUCCESS: an action triggered after wallet reload and the current network settings status is WAITING.
NETWORKSETTINGS_UPDATE_INVALID: an action triggered by update request effect to mark the request as invalid
NETWORKSETTINGS_UPDATE_FAILURE: an action triggered by either the update effect or the persist effect, controlled by the network settings saga, to indicate that the update has failed - [ ] NETWORKSETTINGS_UPDATE_STATUS: action triggered to change network settings status either for READY or LOADING
Statuses
READY: default status
LOADING: once the update request is made
WAITING: once the network settings are persisted
SUCCESSFUL: once the update succeeds
FAILED: once the update fails
The text was updated successfully, but these errors were encountered:
The
NETWORKSETTINGS_*
actions are not conveying the best meaning, as stated in this commit 095510f and this comment on PR(10)#350. Here is a proposal to change it:Actions
NETWORKSETTINGS_UPDATE_REQUEST
: an action triggered by user to update the network settings submitted through the formNETWORKSETTINGS_PERSIST_STORE
: an action triggered by an update effect demanding that the network settings produced by it be persisted in the app storageNETWORKSETTINGS_UPDATE_STATE
: an action triggered by init effect to update the Redux state with the custom network settings storedNETWORKSETTINGS_UPDATE_WAITING
: an action triggered by persist effect to indicate that the persistence is complete and the wallet needs to be reloadedNETWORKSETTINGS_UPDATE_SUCCESS
: an action triggered after wallet reload and the current network settings status isWAITING
.NETWORKSETTINGS_UPDATE_INVALID
: an action triggered by update request effect to mark the request as invalidNETWORKSETTINGS_UPDATE_FAILURE
: an action triggered by either the update effect or the persist effect, controlled by the network settings saga, to indicate that the update has failed- [ ]NETWORKSETTINGS_UPDATE_STATUS
: action triggered to change network settings status either forREADY
orLOADING
Statuses
READY
: default statusLOADING
: once the update request is madeWAITING
: once the network settings are persistedSUCCESSFUL
: once the update succeedsFAILED
: once the update failsThe text was updated successfully, but these errors were encountered: