-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the requirement of the API review? #45
Comments
I am for dropping it, and making it optional, but recommended. As you say, it's not being followed anyway. One could speculate on why it's not being followed. |
I would love to know why?! I had assumed that trying to design a better API by soliciting input and review would be something inherently meaningful and valuable to engineers. Especially given that API design is not something which comes naturally (especially outside-in design) to a software developer. At least I learned a ton by folks with a product focus challenging my api(s). |
My guesses go into the direction of "argh, another process, another thing which will take a lot of my precioussss time." Which I can relate to, even though the API design is something that should be done thoroughly. |
I would still like to see discussions about the way our APIs are designed. The API guidelines document what we think is best practice, but the proof of the pudding is in the eating. We need to see the guidelines applied, understand why developers want to deviate from the guidelines, ideally also get the API consumers' feedback once the APIs are in production for some time. Only then we can learn and improve... |
In Umantis, we are applying the Haufe Style Guidelines when implementing our API’s. Certainly we still don’t have any centralized government similar to the Paypal’s centralized department that we saw in last workshop in Barcelona, but we are planning to do something similar soon. |
I see the API design process as an iterative and team oriented process. |
It is not being followed for over a year now. A mandatory rule being systematically ignored without consequences is worse than having no rule at all. Asking for comments.
The text was updated successfully, but these errors were encountered: