Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect “public” modifier when override methods #439

Closed
anibyl opened this issue Feb 25, 2016 · 2 comments
Closed

Incorrect “public” modifier when override methods #439

anibyl opened this issue Feb 25, 2016 · 2 comments

Comments

@anibyl
Copy link
Contributor

anibyl commented Feb 25, 2016

When I try to override function incorrect public modifier appears always.
Ctrl+O in Bar class:
https://gyazo.com/aa6007675c395775b1bb753585d48e4a
Then I selected all methods to override:
https://gyazo.com/33e974fcc6063a369a2fcaeb8ab2292f
As you can see “protected” methods became “public”.

Repro:

class Main {
    function protectedOperation(s:String):String { return s; }
}

class Foo extends Main {
    // press Ctrl+O here and override protectedOperation
}

https://github.com/TiVo/intellij-haxe/blame/master/src/common/com/intellij/plugins/haxe/ide/generation/OverrideImplementMethodFix.java#L58 was done for interfaces only.

@anibyl anibyl changed the title Incorrect “public” modifier when override mathods Incorrect “public” modifier when override methods Feb 25, 2016
@bynuff
Copy link
Contributor

bynuff commented Feb 26, 2016

+1

@EBatTiVo
Copy link
Contributor

Fixed: 02d8b93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants