Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golden masters out of date, causing FileComparison failures when running unit tests. #71

Closed
EBatTiVo opened this issue Dec 3, 2014 · 2 comments
Labels

Comments

@EBatTiVo
Copy link
Contributor

EBatTiVo commented Dec 3, 2014

Occurs in JetBrains and TiVo repos. There are far fewer of them on the JetBrains repo.

We have made many structural changes in the PSI recently. These come primarily through BNF changes. Tests which parse the PSI tree compare parse results against a "known good" (e.g. golden) set of results. The goldens still have the old structure intact and need 1) verification, and 2) updating.

TIR: STB-5630.

@EBatTiVo
Copy link
Contributor Author

EBatTiVo commented Feb 2, 2015

OK, these were mostly fixed until I added some debug text to the elements. I guess I need to test whether we are running in test mode prior to outputting the extra data.

@EBatTiVo
Copy link
Contributor Author

Debug text was dropped during unit tests in commit 62bdf0a.
Golden's have been updated at various times after that. All goldens match tests at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant