Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Atob to be case-insensitive #18

Closed
Henry-Sarabia opened this issue Mar 10, 2019 · 0 comments
Closed

Change Atob to be case-insensitive #18

Henry-Sarabia opened this issue Mar 10, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0.1

Comments

@Henry-Sarabia
Copy link
Owner

Henry-Sarabia commented Mar 10, 2019 •
edited
Loading

As of v1.0.0, only "true", "True", and "TRUE" are valid string representations of boolean value true. This is the same for the false boolean value. There is no reason to not accept any combination of upper and lowercase characters.
@Henry-Sarabia Henry-Sarabia added the enhancement New feature or request label Mar 10, 2019
@Henry-Sarabia Henry-Sarabia changed the title Allow any case of strings "true" and "false Accept any case of strings "true" and "false" Mar 10, 2019
@Henry-Sarabia Henry-Sarabia added this to the v1.0.1 milestone Mar 10, 2019
@Henry-Sarabia Henry-Sarabia added the good first issue Good for newcomers label Mar 12, 2019
@Henry-Sarabia Henry-Sarabia mentioned this issue Mar 12, 2019
Closed
@Henry-Sarabia Henry-Sarabia changed the title Accept any case of strings "true" and "false" Change Atob to be case-insensitive Aug 1, 2019
@Henry-Sarabia Henry-Sarabia mentioned this issue Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.1
Development

No branches or pull requests
1 participant
@Henry-Sarabia