Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing is destructive #2

Closed
mmaismma opened this issue Jun 2, 2020 · 1 comment · Fixed by #4
Closed

Editing is destructive #2

mmaismma opened this issue Jun 2, 2020 · 1 comment · Fixed by #4
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mmaismma
Copy link
Member

mmaismma commented Jun 2, 2020

Current thumbnail-maker is all functional. But the changes you make cannot be undone i.e. the editing is destructive. The example shown below explains this a lot.

  • Step 1: Add a background image(optional but it helps contrast the issue)
    image
  • Step 2: Add episode number. In this case, I typed 40 as the episode number.
    image
  • Step 3: Change the episode number. I changed it to 24 in this case.
    image
    Where you expect '24' to replace '40', it overwrites it. The same is also true for the background image and HermitCraft logo.
    Making editing non-destructible is all good.
@mmaismma
Copy link
Member Author

mmaismma commented Jun 4, 2020

Currently, the canvas only draws the updated element. A possible solution for this issue is to re-draw the whole canvas on every update.

@mmaismma mmaismma added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 4, 2020
@mmaismma mmaismma pinned this issue Jun 4, 2020
@mmaismma mmaismma changed the title Editing is destructible Editing is destructive Jun 4, 2020
@mmaismma mmaismma unpinned this issue Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant