From f1db3d6dfbcaf2f5cae116144120f65424a3c5f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathis=20Dr=C3=B6ge?= Date: Tue, 21 Nov 2023 23:11:27 +0100 Subject: [PATCH] [Fix/Tech] Fixup Snap publishing in `build-base` workflow (#3223) * Fixup variable name * Set fail-fast to false This prevents all builds from getting cancelled if one fails --- .github/workflows/build-base.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-base.yml b/.github/workflows/build-base.yml index 75c38221c4..14b107d975 100644 --- a/.github/workflows/build-base.yml +++ b/.github/workflows/build-base.yml @@ -15,6 +15,7 @@ on: jobs: build: strategy: + fail-fast: false matrix: os: [windows-2022, ubuntu-22.04, macos-12] runs-on: ${{ matrix.os }} @@ -36,7 +37,7 @@ jobs: sudo apt-get install --no-install-recommends -y snapcraft yarn dist:linux Snap --publish=always env: - SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.snapcraftEdgeId }} + SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.snapcraftIdEdge }} if: runner.os == 'Linux' && inputs.publish-snap - name: Build AppImage version run: yarn dist:linux AppImage