Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude seeds that trigger a bug without causing a crash #54

Open
adrianherrera opened this issue Jan 13, 2021 · 1 comment
Open

Exclude seeds that trigger a bug without causing a crash #54

adrianherrera opened this issue Jan 13, 2021 · 1 comment

Comments

@adrianherrera
Copy link
Member

As ideal sanitization is disabled by default, some seeds that immediately trigger a bug (e.g., the PHP Exif regression tests) are not pruned at https://github.com/HexHive/magma/blob/v1.1/magma/run.sh#L27

The run script should check if ideal sanitization is disabled, and if so, check the monitor for triggered crashes during pruning, and prune those seeds.

@hazimeh
Copy link
Member

hazimeh commented Feb 9, 2021

Following up on our previous discussion, I wonder if this was actually the case or if I had already accounted for it in the pruning stage.
Rationale: the magma/runonce.sh script, on line 31, launches the monitor and observes for triggered bugs, regardless whether or not ISan is enabled. So, seeds are pruned of bugs even in the absence of ISan.
Not sure if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants