-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up in-situ diagnostic #1052
Merged
MaxThevenet
merged 3 commits into
Hi-PACE:development
from
AlexanderSinn:clean_up_insitu_diag
Jan 10, 2024
Merged
Clean-up in-situ diagnostic #1052
MaxThevenet
merged 3 commits into
Hi-PACE:development
from
AlexanderSinn:clean_up_insitu_diag
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSinn
added
cleaning
Code cleaning, avoid duplication, better naming, better style etc.
component: diagnostics
About any types of diagnostics
labels
Dec 18, 2023
MaxThevenet
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this PR! See minor comment below.
9 tasks
MaxThevenet
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
5 tasks
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Jan 23, 2024
## Summary This PR adds TypeMultiplier and MakeZeroTuple from Hi-PACE/hipace#1052 to AMReX. TypeMultiplier can be used to shorten ReduceOps and ReduceData definitions where the same type is used many times. MakeZeroTuple can be used to initialize a GpuTuple to zero (the default constructor would leave the values uninitialized). IdentityTuple can be used to initialize a GpuTuple to the identity elements of each operation in a ReduceOps. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleaning
Code cleaning, avoid duplication, better naming, better style etc.
component: diagnostics
About any types of diagnostics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was relatively tedious to add new quantities to the in-situ diagnostic. This PR automates a few parts to reduce the number of places that need to change for a new quantity from about 11 to just 4 (InSituComputeDiags gpu kernel, InSituWriteToFile output format, m_insitu_nrp in header file and the documentation).
Old:
New:
const
isconst
)