Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: skip PR checking when up to date or livecheck fails #18812

Merged
merged 3 commits into from
Nov 25, 2024
Merged

bump: skip PR checking when up to date or livecheck fails #18812

merged 3 commits into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. bump: skip PR checking when up to date 

    `brew bump` will check for PRs related to a package even if the
package version and livecheck version are the same. We're presumably
only interested in related PRs when the livecheck version differs, so
we can reduce GitHub API requests by skipping the check(s) when the
versions are equal. We use `bump` in `autobump` workflows, so this
should help with recent rate limiting issues (e.g., 3203 out of 3426
autobumped formulae were up to date in a recent run).

This also reworks the output for duplicate PRs, making it clear when
`bump` skipped checking PRs (as printing "none" would suggest that
PRs were checked) and only printing the "Maybe duplicate" information
when checked. This makes it a little easier to understand what `bump`
has done internally from the output.
    @samford
    samford committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a89457f View commit details
    Browse the repository at this point in the history

  2. BumpVersionParser: expand tests 

    This expands test coverage for `BumpVersionParser`, bringing line
coverage to 100% and branch coverage to 95.45%. This is the best we
can do for branch coverage, as Sorbet will catch an invalid argument
type before the method is executed, so we can't exercise the method
in a test to get 100% coverage.
    @samford
    samford committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    918206e View commit details
    Browse the repository at this point in the history

  3. bump: skip PR checking when livecheck fails 

    `brew bump` will check for PRs related to a package even if livecheck
fails to identify new versions. This reworks related conditions to
ensure that related PR checks are only run when livecheck returns
version information.
    @samford
    samford committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1cbcc44 View commit details
    Browse the repository at this point in the history