From a3ab1cba535ad8b83a360ab047cf56fe3475db29 Mon Sep 17 00:00:00 2001 From: Michael Cho Date: Thu, 28 Nov 2024 11:41:04 -0500 Subject: [PATCH] formula_auditor: avoid `pkg-config` dependency in core tap --- Library/Homebrew/formula_auditor.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/Homebrew/formula_auditor.rb b/Library/Homebrew/formula_auditor.rb index 306103a022639..c9e1a438c9b41 100644 --- a/Library/Homebrew/formula_auditor.rb +++ b/Library/Homebrew/formula_auditor.rb @@ -363,8 +363,7 @@ def audit_deps # we want to allow uses_from_macos for aliases but not bare dependencies. # we also allow `pkg-config` for backwards compatibility in external taps. - # TODO: after migrating all `pkg-config` usage to `pkgconf`, do not allow `pkg-config` in core tap - if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && dep.name != "pkg-config" + if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && (dep.name != "pkg-config" || @core_tap) problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." end