-
-
Notifications
You must be signed in to change notification settings - Fork 459
Remove broken font "Source Code Pro" #3973
Comments
Simply removing this won’t work, because it will be added by the script which keeps these up-to-date. Please don’t be reactionary. The first step isn’t to shove workarounds whatever is convenient, but to try to get this resolved upstream, in the Google Fonts repo. |
Dear @vitorgalvao , IMHO this is not a matter of "reactionary" but preventing users from running into issues. BTW, please excuse me if I acted too harshly in the other issue. This was not my intention and as a homebrew user for over ten years I really appreciate your work. |
That was absolutely the wrong word; I meant reactive/rushed and got some brain wires crossed.
That’s demonstrably incorrect. In the last week alone, of the 25 PRs opened 19 were merged, and of the 13 new issues only 5 remain open. Now that I look closer, I see the issue in question is not a PR. That makes it way simpler to understand why it wasn’t fixed yet! They have 1000 issues and only 33 PRs, which do you think they’ll do first and more eagerly: the ones which increase work or the ones which save work? Someone should submit a PR to them instead of submitting to us. As explained before, that’s the resolution that will fix it everywhere. Also pinging @jsgv and @iandol.
Thank you. Apology accepted. Pinging @carlocab. |
Thank you. I'd like to apologise for being less than charitable as well in #3972. |
I have created a tap with the Adobe versions that you can use. @carlocab — the source-code-pro cask has the same name as the official one and that means you have to specify the full path: https://github.com/iandol/homebrew-adobe-fonts
The docs for taps mentions the naming conventions for formulae but not casks: https://docs.brew.sh/Taps |
There’s no difference. |
As stated in the issue #3972, the font "Source Code Pro" is broken in the upstream Google repository.
Due to that, remove it until it is fixed in upstream.
Otherwise this will cause many problems on installations as this version of the font doesn't render correctly anymore, e.g. in Visual Code or Atom.
The text was updated successfully, but these errors were encountered: