DiffMerge Resources references /Applications

[darkn3rd]

I just installed DiffMerge (brew cask install diffmerge), which places it in /opt/homebrew-cask/Caskroom/diffmerge/4.2.0.697/DiffMerge.app.

This normally would not be a problem, but internal shell script, DiffMerge.app/Contents/Resources/diffmerge.sh, as well as the one in the Extras folder refers to its executable as:

DIFFMERGE_PATH=/Applications/DiffMerge.app
DIFFMERGE_EXE=${DIFFMERGE_PATH}/Contents/MacOS/DiffMerge

EXPECTED BEHAVIOR: If this application lives somewhere else, then the support scripts should be updated to refer to the correct location of the application. Thus DIFFMERGE_PATH=/opt/homebrew-cask/Caskroom/diffmerge/4.2.0.697/DiffMerge.app.

[vitorgalvao]

That should be fixed upstream. Not like the script can’t know its own location, and hardcoding the path assuming every user installs to the same location is lazy and leads to these types of issues. We shouldn’t be altering the script, since that is a recipe for disaster when it changes.

Labelled as upstream, and added to #12858 for fixing later.

[darkn3rd]

Until the upstream fix, the broken package should be removed.

Workaround:

curl -O http://download-us.sourcegear.com/DiffMerge/4.2.0/DiffMerge.4.2.0.697.intel.stable.pkg
sudo installer -pkg ~/Downloads/DiffMerge.4.2.0.697.intel.stable.pkg -target /