Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends_on :formula should take install flags #22825

Closed
vitorgalvao opened this issue Jul 15, 2016 · 1 comment
Closed

depends_on :formula should take install flags #22825

vitorgalvao opened this issue Jul 15, 2016 · 1 comment

Comments

@vitorgalvao
Copy link
Member

Refs #8784.

We need to both add the option to supply install flags and a way to check if the relevant formula was compiled with the relevant flags (since it currently only checks if it was installed at all).

Also

Each depends_on stanza may only contain one of:

  • :formula with optional :options (and any future args such as :version)
  • :cask with optional :options (and any future args such as :version)
  • :macos
  • :arch
  • :x11
  • :java

It would look something like

depends_on :formula => 'mkvtoolnix'
depends_on :formula => 'ffmpeg',
           :version => '>= 2.5.2',
           :options => %w{ --with-faac --with-fdk-aac }

Also, perhaps we will be able to leverage this directly from homebrew, with the merger.

@vitorgalvao vitorgalvao added enhancement core Issue with Homebrew itself rather than with a specific cask. ready to implement labels Jul 15, 2016
@vitorgalvao
Copy link
Member Author

There was a single group of casks that benefited from this, and we don’t have them anymore. This isn’t as necessary as originally thought. Closing.

@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement ready to implement labels Feb 2, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants