Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corepack not installed with formula node #151439

Closed
4 tasks done
danfuzz opened this issue Oct 17, 2023 · 2 comments
Closed
4 tasks done

corepack not installed with formula node #151439

danfuzz opened this issue Oct 17, 2023 · 2 comments
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age

Comments

@danfuzz
Copy link

danfuzz commented Oct 17, 2023

brew gist-logs <formula> link OR brew config AND brew doctor output

$ brew config
HOMEBREW_VERSION: 4.1.16
ORIGIN: https://github.com/Homebrew/brew
HEAD: c0c8a4dd4dd19ec16deb429abd50cdf82ea33b27
Last commit: 3 days ago
Core tap JSON: 17 Oct 16:52 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: emacs-console
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 15.0.0 build 1500
Git: 2.39.3 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 8.1.2 => /usr/bin/curl
macOS: 13.6-arm64
CLT: 15.0.0.0.1.1694021235
Xcode: 15.0
Rosetta 2: false
$ brew doctor
Your system is ready to brew.
$ 

Verification

  • My "brew doctor output" says Your system is ready to brew. and am still able to reproduce my issue.
  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.
  • I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

Use corepack, which per Node documentation is supposed to be part of all recent Node releases. See https://nodejs.org/api/corepack.html. (Note that it is listed as "experimental," but in the usual Node meaning that wouldn't typically prevent it from being part of a build.)

As to why, because I'm trying to follow the build instructions for a different project (Pulsar, https://pulsar-edit.dev/docs/launch-manual/sections/core-hacking/#building-pulsar).

What happened (include all command output)?

$ brew upgrade node
==> Downloading https://formulae.brew.sh/api/formula.jws.json
##O#- #                                                                        
==> Downloading https://formulae.brew.sh/api/cask.jws.json
######################################################################### 100.0%
==> Upgrading 1 outdated package:
node 20.7.0 -> 20.8.1
==> Downloading https://ghcr.io/v2/homebrew/core/node/manifests/20.8.1-1
######################################################################### 100.0%
==> Fetching dependencies for node: c-ares and libnghttp2
==> Downloading https://ghcr.io/v2/homebrew/core/c-ares/manifests/1.20.1
######################################################################### 100.0%
==> Fetching c-ares
==> Downloading https://ghcr.io/v2/homebrew/core/c-ares/blobs/sha256:c4c691f0df9
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/libnghttp2/manifests/1.57.0
######################################################################### 100.0%
==> Fetching libnghttp2
==> Downloading https://ghcr.io/v2/homebrew/core/libnghttp2/blobs/sha256:a2608f7
######################################################################### 100.0%
==> Fetching node
==> Downloading https://ghcr.io/v2/homebrew/core/node/blobs/sha256:90a2e545f6332
######################################################################### 100.0%
==> Upgrading node
  20.7.0 -> 20.8.1 

==> Installing dependencies for node: c-ares and libnghttp2
==> Installing node dependency: c-ares
==> Downloading https://ghcr.io/v2/homebrew/core/c-ares/manifests/1.20.1
Already downloaded: /Users/danfuzz/Library/Caches/Homebrew/downloads/aaf2cda823b470bd269e2869aad8a2174a8f635e6c59592c115242735375cea2--c-ares-1.20.1.bottle_manifest.json
==> Pouring c-ares--1.20.1.arm64_ventura.bottle.tar.gz
🍺  /opt/homebrew/Cellar/c-ares/1.20.1: 85 files, 651.5KB
==> Installing node dependency: libnghttp2
==> Downloading https://ghcr.io/v2/homebrew/core/libnghttp2/manifests/1.57.0
Already downloaded: /Users/danfuzz/Library/Caches/Homebrew/downloads/38b8e77aafeea97ca6c05954b9694ee637d601edc08f5836177e09c9ceef3162--libnghttp2-1.57.0.bottle_manifest.json
==> Pouring libnghttp2--1.57.0.arm64_ventura.bottle.tar.gz
🍺  /opt/homebrew/Cellar/libnghttp2/1.57.0: 13 files, 737.4KB
==> Installing node
==> Pouring node--20.8.1.arm64_ventura.bottle.1.tar.gz
🍺  /opt/homebrew/Cellar/node/20.8.1: 2,519 files, 58.6MB
==> Running `brew cleanup node`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /opt/homebrew/Cellar/node/20.7.0... (2,517 files, 58.4MB)
Removing: /Users/danfuzz/Library/Caches/Homebrew/node--20.7.0... (14.7MB)
==> Upgrading 2 dependents of upgraded formulae:
Disable this behaviour by setting HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
nghttp2 1.52.0 -> 1.57.0, unbound 1.17.1 -> 1.18.0_1
==> Downloading https://ghcr.io/v2/homebrew/core/nghttp2/manifests/1.57.0
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/unbound/manifests/1.18.0_1
Already downloaded: /Users/danfuzz/Library/Caches/Homebrew/downloads/2be2c3b3f225d8443899e58a9d758a6083e106ff6447128e93d24c37999dc86f--unbound-1.18.0_1.bottle_manifest.json
==> Checking for dependents of upgraded formulae...
==> No broken dependents found!
$ which corepack
$

What did you expect to happen?

$ which corepack
/opt/homebrew/bin/corepack
$

Step-by-step reproduction instructions (by running brew commands)

  • brew upgrade node

or

  • brew install node if you don't already have it installed.
@danfuzz danfuzz added the bug Reproducible Homebrew/homebrew-core bug label Oct 17, 2023
@cho-m
Copy link
Member

cho-m commented Oct 17, 2023

Did you try brew install corepack? https://formulae.brew.sh/formula/corepack#default

We keep corepack fully up-to-date as separate formula and have disabled copy in node formula

--without-corepack

(also see discussion at #91540)

Homebrew's older Nodes do include corepack probably to guarantee a compatible version,

brew which-formula corepack
corepack
node@14
node@16
node@18

@danfuzz
Copy link
Author

danfuzz commented Oct 17, 2023

@cho-m Thanks for the pointer. I missed that corepack was bundled separately.

@danfuzz danfuzz closed this as completed Oct 17, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

2 participants