Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identme 0.5 (new formula) #206325

Closed
wants to merge 1 commit into from
Closed

identme 0.5 (new formula) #206325

wants to merge 1 commit into from

Conversation

pcarrier
Copy link
Contributor

@pcarrier pcarrier commented Feb 2, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 2, 2025
@SMillerDev
Copy link
Member

Hi, this seems like a nice software, but not notable enough for us to package in Homebrew for now. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future.

Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 4, 2025

Thanks @SMillerDev. Already doing so. Hoping to get to 75 stars soon :)

@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 5, 2025

We have 75 stars.

@pcarrier pcarrier closed this Feb 5, 2025
@pcarrier pcarrier reopened this Feb 5, 2025
@pcarrier pcarrier marked this pull request as draft February 5, 2025 16:42
@pcarrier pcarrier marked this pull request as ready for review February 5, 2025 16:42
@pcarrier pcarrier closed this Feb 5, 2025
@pcarrier pcarrier reopened this Feb 5, 2025
@pcarrier pcarrier closed this Feb 5, 2025
@pcarrier pcarrier reopened this Feb 5, 2025
@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 5, 2025

Sorry for the noise, fighting CI. Looks like closing and reopening too fast caused cancellations.

Formula/i/identme.rb Outdated Show resolved Hide resolved
Formula/i/identme.rb Outdated Show resolved Hide resolved
@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 5, 2025

Oops, no idea what happened there, sorry.

@pcarrier pcarrier reopened this Feb 5, 2025
@pcarrier pcarrier requested a review from chenrui333 February 5, 2025 20:56
@pcarrier pcarrier changed the title identme 0.2.1 (new formula) identme 0.3 (new formula) Feb 6, 2025
@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 6, 2025

Upgraded to 0.3.

@pcarrier pcarrier changed the title identme 0.3 (new formula) identme 0.4 (new formula) Feb 7, 2025
@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 7, 2025

v0.4 just released. Added --json and dropped the timing information (easy to run in time when interested).

@pcarrier pcarrier force-pushed the master branch 3 times, most recently from 69ecedb to 2f3f623 Compare February 8, 2025 00:09
@pcarrier pcarrier changed the title identme 0.4 (new formula) identme 0.5 (new formula) Feb 8, 2025
@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 8, 2025

v0.5 just released. Added -4 and -6 to limit queries, non-zero exit code on absence of results.

Formula/i/identme.rb Outdated Show resolved Hide resolved
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice this before, but from the docs:

We frown on authors submitting their own work unless it is very popular.

https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

I'll leave it to other maintainers to merge this or not.

@pcarrier
Copy link
Contributor Author

pcarrier commented Feb 9, 2025

Same question as #206921: would it be better if I closed this, someone in my community opened another PR, possibly copying the formula from this PR or my tap?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 12, 2025
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 12, 2025
@pcarrier pcarrier closed this Feb 12, 2025
@zionts zionts mentioned this pull request Feb 12, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants