Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install custom tap anymore #55781

Closed
4 tasks done
coding-red-panda opened this issue Jun 4, 2020 · 4 comments
Closed
4 tasks done

Unable to install custom tap anymore #55781

coding-red-panda opened this issue Jun 4, 2020 · 4 comments
Labels
outdated PR was locked due to age

Comments

@coding-red-panda
Copy link

coding-red-panda commented Jun 4, 2020

  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
  • if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

Because we have to deal with legacy software, we need a dependency on the OpenSSL 1.0 Formula. For this reason, we have created a special tap that we use in projects to be able to install openssl@1.0 alongside the normal openssl provided by HomeBrew.

People trying to set up their macbooks (or those performing reinstalls) are unable to install this tap because HomeBrew is mangling up the download URLs in the Formula.

What happened (include command output)

People running the brew install openssl@1.0 command or the brew reinstall openssl@1.0 command receive the following output:

==> Downloading https://homebrew.bintray.com/bottles/openssl%401.0-1.0.2t.catalina.bottle.tar.gz
#=#=-#  #                                                                     
curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "openssl@1.0"
Download failed: https://homebrew.bintray.com/bottles/openssl%401.0-1.0.2t.catalina.bottle.tar.gz

The problem is that Homebrew for some reason seems to replace the openssl in the name with openssl@1.0 which breaks the URL. Manually downloading the bottle actually still works.

Correct URL

What you expected to happen

I expect HomeBrew to respect the URL defined in the tap Formula

Step-by-step reproduction instructions (by running brew install commands)

brew tap customink/openssl-1.0
brew install openssl@1.0

Gist logs

Error: No logs.

Brew Config

HOMEBREW_VERSION: 2.3.0-35-g0af7a28
ORIGIN: https://github.com/Homebrew/brew
HEAD: 0af7a28fb817d1889aeef587dcf7f31f660d8e46
Last commit: 6 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: d043c3bc993728c0c2f05ebb13f8515640aeef26
Core tap last commit: 75 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_MAKE_JOBS: 16
CPU: 16-core 64-bit kabylake
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
Clang: 11.0 build 1103
Git: 2.24.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.5-x86_64
CLT: 1103.0.32.29
Xcode: 11.5

Brew Doctor

Your system is ready to brew.
@SMillerDev
Copy link
Member

That's because the formula used to be called openssl and it'll take the formula name to construct the bottle URL. You'll need to make your own bottles of you want to provide bottles.

@coding-red-panda
Copy link
Author

Is there a guide on how I can do that in the given situation?
Because most commands fail since it tries to download the wrong URL.

Also does not explain that this worked without any issues several weeks ago

@Bo98
Copy link
Member

Bo98 commented Jun 4, 2020

It shouldn’t have ever worked. Existing bottles have never been able to be used as the contents of those bottles cannot be reused for a formula with a different name (openssl@1.0 is a different name): Homebrew/brew#6059 (comment)

In the event of a missing bottle however, Homebrew should fall back to building from source (unless HOMEBREW_DEVELOPER is set).

@coding-red-panda
Copy link
Author

well it worked in the past, and probably because the alias/symlink for openssl was still pointing to my 1.0 installation, which is now gone.

I've updated our tap to remove the bottle entries and always build the Formula from source for our developer setup. Minor inconvenience, but at least people are able to setup their system now.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 2, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

4 participants