-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jdtls 1.13.0 #104924
jdtls 1.13.0 #104924
Conversation
Error: jdtls: failed |
Looks like this release requires Java 17. If I change line 30 from
|
EOFError: end of file reached |
fix build Signed-off-by: Rui Chen <rui@chenrui.dev>
ae907f8
to
962139d
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
depends_on "openjdk@11" | ||
depends_on "python@3.9" | ||
depends_on "openjdk" | ||
depends_on "python@3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libexec/"bin/jdtls"
uses #!/usr/bin/env python3
, so it won't work as is with python@3.10
. This should end up falling back to Python 3.8 on macOS, but script needs Python 3.9 at minimum.
Can either do a shebang rewrite, or a PATH override in env script.
Not sure if this is what is causing current test failure though.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
Created with
brew bump-formula-pr
.