Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdtls 1.13.0 #104924

Closed
wants to merge 1 commit into from
Closed

jdtls 1.13.0 #104924

wants to merge 1 commit into from

Conversation

Porkepix
Copy link
Contributor

@Porkepix Porkepix commented Jul 2, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` java Java use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Jul 2, 2022
@chenrui333
Copy link
Member

Error: jdtls: failed
An exception occurred within a child process:
EOFError: end of file reached

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Jul 2, 2022
@issyl0
Copy link
Member

issyl0 commented Jul 2, 2022

Looks like this release requires Java 17. If I change line 30 from 11 to 17 and reinstall, printing _e.read in the test reveals:

"Traceback (most recent call last):\n" +
"  File \"/opt/homebrew/Cellar/jdtls/1.13.0/libexec/bin/jdtls\", line 17, in <module>\n" +
"    jdtls.main(sys.argv[1:])\n" +
"  File \"/opt/homebrew/Cellar/jdtls/1.13.0/libexec/bin/jdtls.py\", line 75, in main\n" +
"    java_executable = get_java_executable(known_args.validate_java_version)\n" +
"  File \"/opt/homebrew/Cellar/jdtls/1.13.0/libexec/bin/jdtls.py\", line 31, in get_java_executable\n" +
"    out = subprocess.check_output([java_executable, '-version'], stderr = subprocess.STDOUT, universal_newlines=True)\n" +
"  File \"/opt/homebrew/Cellar/python@3.9/3.9.13/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py\", line 424, in check_output\n" +
"    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,\n" +
"  File \"/opt/homebrew/Cellar/python@3.9/3.9.13/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py\", line 528, in run\n" +
"    raise CalledProcessError(retcode, process.args,\n" +
"subprocess.CalledProcessError: Command '['java', '-version']' returned non-zero exit status 1.\n"

@chenrui333 chenrui333 removed the test failure CI fails while running the test-do block label Jul 2, 2022
@chenrui333
Copy link
Member

EOFError: end of file reached

fix build

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the bump-jdtls-1.13.0 branch from ae907f8 to 962139d Compare July 2, 2022 19:22
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 4, 2022
@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed stale No recent activity labels Jul 5, 2022
depends_on "openjdk@11"
depends_on "python@3.9"
depends_on "openjdk"
depends_on "python@3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libexec/"bin/jdtls" uses #!/usr/bin/env python3, so it won't work as is with python@3.10. This should end up falling back to Python 3.8 on macOS, but script needs Python 3.9 at minimum.

Can either do a shebang rewrite, or a PATH override in env script.

Not sure if this is what is causing current test failure though.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 7, 2022
@github-actions github-actions bot closed this Jul 9, 2022
@branchvincent branchvincent mentioned this pull request Jul 31, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@Porkepix Porkepix deleted the bump-jdtls-1.13.0 branch March 22, 2023 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue outdated PR was locked due to age python Python use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants