Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdtls 1.13.0 #104924

Closed
wants to merge 1 commit into from
Closed

jdtls 1.13.0 #104924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Formula/jdtls.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
class Jdtls < Formula
desc "Java language specific implementation of the Language Server Protocol"
homepage "https://github.com/eclipse/eclipse.jdt.ls"
url "https://download.eclipse.org/jdtls/milestones/1.12.0/jdt-language-server-1.12.0-202206011637.tar.gz"
version "1.12.0"
sha256 "38f20fec27a8fcdb1b3c49a117629dd0800b161171afd4b894bdc026f2fca2f3"
url "https://download.eclipse.org/jdtls/milestones/1.13.0/jdt-language-server-1.13.0-202206301721.tar.gz"
version "1.13.0"
sha256 "5a29ad28d765f408106a87b147b239696942a11f22f950c52dc37176fce9cfc9"
license "EPL-2.0"
version_scheme 1

Expand All @@ -16,8 +16,8 @@ class Jdtls < Formula
sha256 cellar: :any_skip_relocation, all: "5af62f9cf5c42b7ba320b51901224ca87593475a80d292beeb3cbd9aede5e50f"
end

depends_on "openjdk@11"
depends_on "python@3.9"
depends_on "openjdk"
depends_on "python@3.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libexec/"bin/jdtls" uses #!/usr/bin/env python3, so it won't work as is with python@3.10. This should end up falling back to Python 3.8 on macOS, but script needs Python 3.9 at minimum.

Can either do a shebang rewrite, or a PATH override in env script.

Not sure if this is what is causing current test failure though.


def install
libexec.install "bin"
Expand All @@ -27,7 +27,7 @@ def install
libexec.install "plugins"

(bin/"jdtls").write_env_script libexec/"bin/jdtls",
Language::Java.overridable_java_home_env("11")
Language::Java.overridable_java_home_env
chenrui333 marked this conversation as resolved.
Show resolved Hide resolved
end

test do
Expand Down