ponyc 0.11.0

[SeanTAllen]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[neutric]

@SeanTAllen Thank you for keeping this formula up to date!

[SeanTAllen]

@neutric I take it the process has changed as this was closed without committing? I'd like to update our release docs to indicate when we can know that the homebrew side of things is finished. How would we verify the "release is done"?

[ilovezfs]

@neutric neutric closed this in b65d360 18 minutes ago

[SeanTAllen]

@ilovezfs so, how do we know this has been done? should i update our docs to say "when the issue is closed and you've been thanked for keeping the formula up to date"?

[ilovezfs]

Well, it's possible you may receive an emoji such as 🙇‍♂️ or 🎉 so that might not be accurate in all cases.

[neutric]

@ilovezfs Thanks for filling in for me!

@SeanTAllen I am not sure I understand the problem as the process was exactly how it has been the last couple of times. How about referring to the formula itself in your docs? If it shows the new version, all is good to go.

[SeanTAllen]

@neutric We, the Pony core team, are the ones opening the PRs for Homebrew. We don't announce our releases until the Homebrew PR is merged. Our current instructions say to wait for the PR to be merged, however, it appears at some point your process changed and the PR itself it no longer merged. I want to update our instructions accordingly, however, I'm not sure what the best way to know that the PR has been accepted. PR closed itself doesn't seem indicative of PR accepted.

[neutric]

@SeanTAllen Thanks for the explanation! I haven't been a maintainer for long, so I can't shed light on why PRs that require new bottles to be built are not merged directly but done the way you can see above (that is, with a commit by a maintainer that mirrors your PR + tweaks if needed). A rejection would be missing that commit and would also give a reason for why we did not accept the PR. Does this help?

[SeanTAllen]

@neutric yes. so there should be some variation on a "thank you!" or "PR accepted" message even though the PR was closed, yes?

[neutric]

That is correct, except for those cases where this message gets forgotten. What is always there is the commit that is closing the PR:

neutric closed this in b65d360 18 hours ago

I just had a look at what I think is the doc you are referring to. If you fear there is a risk for your team members to misinterpret what happened in the PR because it has the "closed" icon instead of the "merged" icon despite of the timeline showing a commit right before the closing event that brings the formula up to date (which is missing from rejected PRs such as this), how about saying something to the tune of "wait for the formula to reflect the version bump"?

[ilovezfs]

You can also operationalize that by telling them to check the version of

$ curl -sL https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/ponyc.rb | grep url
  url "https://github.com/ponylang/ponyc/archive/0.11.0.tar.gz"

[SeanTAllen]

Thanks @ilovezfs. Updating our documentation. Y'all rock!