Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml 5.0.0 ocaml@4.14 4.14.0 (new formula) #118465

Closed
wants to merge 4 commits into from
Closed

ocaml 5.0.0 ocaml@4.14 4.14.0 (new formula) #118465

wants to merge 4 commits into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 18, 2022 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

4.14 is LTS release, https://discuss.ocaml.org/t/the-road-to-ocaml-5-0/8584

Long term support for OCaml 4.14
While OCaml 5 is stabilising, we plan to extend the support period for OCaml 4.14 by publishing minor bugfix releases whenever needed. In particular, OCaml 4.14 will be supported until all tier-1 architectures and operating systems are available in OCaml 5, and OCaml 5 sequential performance is close enough to that of OCaml 4.

@BrewTestBot BrewTestBot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Dec 18, 2022
@chenrui333
Copy link
Member Author

chenrui333 commented Dec 18, 2022 •
edited
Loading

failed to build camlp5, upstream issue, camlp5/camlp5#95

build failure 
==> ./configure --prefix /opt/homebrew/Cellar/camlp5/8.00.04 --mandir /opt/homebrew/Cellar/camlp5/8.00.04/share/man
./configure: /opt/homebrew/opt/ocaml/bin/ocaml: /opt/homebrew/bin/ocamlrun: bad interpreter: No such file or directory
./configure: /opt/homebrew/opt/ocaml/bin/ocaml: /opt/homebrew/bin/ocamlrun: bad interpreter: No such file or directory

Resulting configuration file (config/Makefile.cnf):

MODE=S
EXE=
OPT=.opt
EXT_OBJ=.o
EXT_LIB=.a
OVERSION=5.0.0
VERSION=8.00.04
OCAMLC_W_Y="-w y"
WARNERR="-warn-error +A-11"
NO_PR_DIR=--no-print-directory
OLIBDIR=/opt/homebrew/lib/ocaml
export C5PACKAGES=compiler-libs,camlp-streams
PREFIX=/opt/homebrew/Cellar/camlp5/8.00.04
OTOPU=$(TOP)/ocaml_stuff/5.0.0/utils
BINDIR=$(PREFIX)/bin
LIBDIR=$(PREFIX)/lib/ocaml
MANDIR=/opt/homebrew/Cellar/camlp5/8.00.04/share/man
OCAMLN=ocaml
CAMLP5N=camlp5

=== strict mode ===

==> make world.opt
/Applications/Xcode.app/Contents/Developer/usr/bin/make core
set -e; cd ocaml_stuff; /Applications/Xcode.app/Contents/Developer/usr/bin/make; cd ..
cd ./5.0.0/utils; \
	/Applications/Xcode.app/Contents/Developer/usr/bin/make all EXE= OCAMLN=ocaml
ocamlc  -c warnings.mli
ocamlc  -c pconfig.mli
File "command line", line 1:
Error: Unbound module StdlibFile "command line", line 1:
Error: Unbound module Stdlib

@chenrui333
Copy link
Member Author

lablgtk failed to build with ocaml5, garrigue/lablgtk#156

@chenrui333 chenrui333 added upstream issue An upstream issue report is needed build failure CI fails while building the software labels Dec 18, 2022
@chenrui333 chenrui333 changed the title ocaml 5.0.0 ocaml 5.0.0 ocaml@4.14 4.14.0 (new formula) Dec 18, 2022
@chenrui333 chenrui333 added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 18, 2022
@chenrui333 chenrui333 force-pushed the bump-ocaml-5.0.0 branch 2 times, most recently from dfeebfa to c139679 Compare December 24, 2022 15:32
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 24, 2022
@chenrui333 chenrui333 force-pushed the bump-ocaml-5.0.0 branch 2 times, most recently from d9da868 to 2eb4ddd Compare December 24, 2022 16:04
@chenrui333 chenrui333 mentioned this pull request Dec 24, 2022
Closed
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label Jan 14, 2023
@chenrui333 chenrui333 mentioned this pull request Jan 21, 2023
Closed
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Jan 21, 2023
@chenrui333 chenrui333 force-pushed the bump-ocaml-5.0.0 branch 2 times, most recently from 38c2588 to bcfde0d Compare January 21, 2023 22:19
@chenrui333 chenrui333 removed the build failure CI fails while building the software label Jan 21, 2023
@p-linnane p-linnane mentioned this pull request Jan 30, 2023
Closed
@smorimoto
Copy link
Contributor

What is the status of this PR?

@SMillerDev
Copy link
Member

Build is failing so not mergable

chenrui333 and others added 4 commits February 19, 2023 19:18
@chenrui333
ocaml 5.0.0
9a54707 
Signed-off-by: Rui Chen <rui@chenrui.dev>

`ocaml@5.0` -> `ocaml@5`

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
ocaml@4.14 4.14.0 (new formula)
3530af2 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
ledit 2.06
fbe8739 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@p-linnane @chenrui333
ott 0.33
62d0acc 
ott: add `ocaml-findlib` dependency
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue labels Feb 19, 2023
This was referenced Feb 19, 2023
Closed
Open
Closed
Closed
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 19, 2023
This was referenced Feb 19, 2023
Closed
Closed
@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 20, 2023
@p-linnane p-linnane removed the in progress Stale bot should stay away label Apr 1, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 27, 2023
@github-actions github-actions bot closed this May 4, 2023
@osalbahr osalbahr mentioned this pull request Jul 31, 2023
Closed
@osalbahr
Copy link
Contributor

osalbahr commented Jul 31, 2023 •
edited
Loading

What is the status of this PR?

I opened a new PR since the build errors were resolved upstream. There are however errors with a couple dependents.

@chenrui333
Copy link
Member Author

I opened a new PR since the build errors were resolved upstream. There are however errors with a couple dependents.

that would be the issue of upgrading the formula

@osalbahr
Copy link
Contributor

osalbahr commented Jul 31, 2023 •
edited
Loading

I opened a new PR since the build errors were resolved upstream. There are however errors with a couple dependents.

that would be the issue of upgrading the formula

Are you saying ocaml@4.14 is needed for ocaml-findlib (and maybe camlp-streams)?

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
@chenrui333 chenrui333 deleted the bump-ocaml-5.0.0 branch January 22, 2024 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age stale No recent activity upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenrui333 @smorimoto @SMillerDev @osalbahr @BrewTestBot @p-linnane