Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch 2.0.1 torchvision 0.15.2 #130487

Merged
merged 4 commits into from
Jun 26, 2023
Merged

pytorch 2.0.1 torchvision 0.15.2 #130487

merged 4 commits into from
Jun 26, 2023

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 8, 2023 •
edited
Loading

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 8, 2023
@chenrui333 chenrui333 force-pushed the bump-pytorch-2.0.1 branch from bc31a60 to b1cceb4 Compare May 8, 2023 21:51
@chenrui333 chenrui333 changed the title pytorch 2.0.1 pytorch 2.0.1 torchvision 0.15.2 May 8, 2023
@chenrui333 chenrui333 force-pushed the bump-pytorch-2.0.1 branch from b1cceb4 to b6c46c5 Compare May 9, 2023 10:51
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label May 9, 2023
@p-linnane p-linnane force-pushed the bump-pytorch-2.0.1 branch 2 times, most recently from 1b9a874 to 7f68e2b Compare May 9, 2023 22:58
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label May 12, 2023
@github-actions github-actions bot closed this May 14, 2023
@chenrui333 chenrui333 reopened this May 19, 2023
@chenrui333 chenrui333 force-pushed the bump-pytorch-2.0.1 branch from 7f68e2b to ba5f9db Compare May 19, 2023 20:09
@chenrui333 chenrui333 added in progress Stale bot should stay away CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed stale No recent activity labels May 19, 2023
@chenrui333 chenrui333 force-pushed the bump-pytorch-2.0.1 branch from ba5f9db to 0c037c4 Compare May 21, 2023 11:30
@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels May 21, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label May 21, 2023
@chenrui333
Copy link
Member Author

only failed on 13-arm

    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:16:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:188:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:386:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:548:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:729:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    /tmp/pytorch-20230521-17010-1orpcas/third_party/fbgemm/src/FbgemmFP16UKernelsAvx2.cc:929:8: error: unknown token in expression
          ".intel_syntax noprefix\t\n"
           ^
    <inline asm>:2:18: note: instantiated into assembly here
            mov [rbp - 48], %r14
                            ^
    6 errors generated.

@carlocab carlocab mentioned this pull request Jun 6, 2023
Merged
@carlocab
Copy link
Member

carlocab commented Jun 6, 2023

Needs rebase. 13-x86_64 failure probably needs reporting upstream, as it was happening in #131405 too.

@chenrui333 chenrui333 force-pushed the bump-pytorch-2.0.1 branch 2 times, most recently from b50379d to 502c732 Compare June 17, 2023 20:59
@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. ready to merge PR can be merged once CI is green labels Jun 17, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 18, 2023
@chenrui333
Copy link
Member Author

Good to be merged now 🍻

@carlocab
Copy link
Member

Still needs upstream report -- Intel Ventura failed.

@carlocab carlocab added the upstream issue An upstream issue report is needed label Jun 18, 2023
@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Jun 18, 2023
chenrui333 and others added 2 commits June 25, 2023 16:33
@chenrui333 @nandahkrishna @carlocab
pytorch 2.0.1
46a31d5 
Also, remove `openssl@1.1` dependency.

Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 @carlocab
torchvision 0.15.2
1d42a7b 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 25, 2023
@carlocab carlocab force-pushed the bump-pytorch-2.0.1 branch from 502c732 to 1d42a7b Compare June 25, 2023 08:34
@carlocab carlocab mentioned this pull request Jun 25, 2023
Closed
carlocab
carlocab approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this along, but can someone please report the pytorch build failure on macOS 13-x86_64 upstream?

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 25, 2023
@carlocab carlocab mentioned this pull request Jun 26, 2023
Closed
@github-actions
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 26, 2023
@BrewTestBot BrewTestBot enabled auto-merge June 26, 2023 04:15
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 26, 2023
Merged via the queue into Homebrew:master with commit bbe27f4 Jun 26, 2023
@chenrui333 chenrui333 deleted the bump-pytorch-2.0.1 branch January 22, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-requeued PR has been re-added to the queue in progress Stale bot should stay away long build Set a long timeout for formula testing upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @carlocab @BrewTestBot