rpm: update livecheck #132158
Merged
rpm: update livecheck #132158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samford
added
livecheck
github-actions
bot
added
the
lua
nandahkrishna
approved these changes
May 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The existing
livecheckblock forrpmis returning4.18.90as the newest version but this corresponds to "RPM 4.19 ALPHA" on the first-party download page. This PR resolves the issue by updating the regex to omit versions with a 90+ patch version, so the check will correctly return 4.18.1 as the newest version.For what it's worth, this regex uses a modified version of the usual
v?(\d+\.\d+\.(?:\d|[1-8]\d+)(?:\.\d+)*)pattern. The difference is that the modified pattern in this PR will also match versions without a patch (or beyond), if upstream were to ever release something like 4.19 instead of 4.19.0 (or 4.19.0.1). There aren't any active examples of this currently but it's arguably better to account for it than to have this quietly fail to match a version in the future.