Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdu: rename binary to gdu-go to mitigate conflict with coreutils #134668

Closed
wants to merge 1 commit into from
Closed

gdu: rename binary to gdu-go to mitigate conflict with coreutils #134668

wants to merge 1 commit into from

Conversation

dundee
Copy link
Contributor

@dundee dundee commented Jun 22, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jun 22, 2023
carlocab
carlocab reviewed Jun 22, 2023
View reviewed changes
Formula/gdu.rb Outdated Show resolved Hide resolved
@dundee dundee requested a review from carlocab June 22, 2023 18:46
@github-actions
Copy link
Contributor

:shipit: @carlocab has requested creation of a replacement PR.

@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2023
Merged
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Jun 23, 2023
@BrewTestBot BrewTestBot marked this pull request as draft June 23, 2023 06:05
@github-actions
Copy link
Contributor

✅ @carlocab replacement PR created at #134722.

carlocab
carlocab reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will be merged in #134722.

@carlocab
Copy link
Member

carlocab commented Jun 23, 2023 •
edited
Loading

The other PR should merge soon. When you open your next PR, please ask for the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label to be applied. Thanks!

github-merge-queue bot pushed a commit that referenced this pull request Jun 23, 2023
@BrewTestBot
Merge pull request #134722 from Homebrew/PR/134668
fe07ff2 
Replacement for #134668
@dundee
Copy link
Contributor Author

dundee commented Jun 23, 2023

Thanks! Next PR in #134731

we11adam added a commit to we11adam/gdu that referenced this pull request Aug 27, 2023
@we11adam
doc: reflect binary name in macOS with a Homebrew installation
197778b 
see: Homebrew/homebrew-core#134668
This was referenced Aug 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request go Go use is a significant feature of the PR or issue superseded PR was replaced by another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dundee @carlocab