pybind11 2.6.0 #63231
pybind11 2.6.0 #63231
Conversation
BrewTestBot
added
the
python
|
Please hold for #62560 |
|
Actually, in its current form, this recipe does not need or touch a specific version of Python. It only installs headers and CMake files. We could change it so the Python module is also installed, or we could change it so that Python is not searched on the configure step and drop the Python requirement except for testing. |
|
Why does it depend on python, then? If it's not necessary, by all means let's remove it! (make it test-only) |
Historical, the CMake files were not flexible enough to not look for Python even if all you were doing was installing headers and configure files. Now there is a switch. Keep in mind, if any other formulas use this one to build, there is a bug in CPython 3.9.0 that causes pybind11 < 2.6 extensions to segfault (UB on all platforms, but random segfaulta on macOS). It's worked around in pybind11 2.6, and patched in CPython 3.9 and dev branches. Conda-forge has already applied the patch to their Python 3.9.0 build, maybe homebrew should too? |
|
Formulas using this one: If pybind11 2.6 works around the issue, I don't see a reason to carry the patch at python/cpython#22674 (unless some other code is known to hit the bug?) |
|
Many libraries bundle pybind11 via submodule or use the PyPI package (even PyTorch does, even if libTorch does not), so it can't be fully controlled here. So I think it still might be a good idea. PyTorch is currently working on upgrading past 2.3, due to a change in 2.4 that broke mixing compilers (which PyTorch could do when JIT compiling). |
fxcoudert
force-pushed
the
bump-pybind11-2.6.0
branch
from
fa5e9fc
to
27bde2e
Compare
|
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr.