Skip to content

Commit

Permalink
fix: resolving mismatched peerDeps
Browse files Browse the repository at this point in the history
  • Loading branch information
whilke committed Apr 4, 2019
1 parent b78f418 commit eca4e13
Show file tree
Hide file tree
Showing 20 changed files with 2,764 additions and 253 deletions.
371 changes: 199 additions & 172 deletions arm-helper/package-lock.json

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions arm-helper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,13 @@
},
"peerDependencies": {
"@azbake/core": "0.*",
"@azure/arm-resources": "0.*"
"@azure/arm-resources": "1.*"
},
"devDependencies": {
"@azbake/core": "0.*",
"@azure/arm-resources": "1.*",
"@types/node": "^10.12.18"
},
"dependencies": {
"@azbake/core": "^0.1.30",
"@azure/arm-resources": "^1.0.1"
},
"publishConfig": {
"access": "public"
},
Expand Down
549 changes: 541 additions & 8 deletions core/package-lock.json

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,12 @@
"test": "mocha --timeout 30000 -r ts-node/register test/**/*.ts"
},
"peerDependencies": {
"@azure/ms-rest-nodeauth": "0.*",
"colors": "^1.3.3"
},
"dependencies": {
"@azure/ms-rest-nodeauth": "^0.9.1",
"@azure/ms-rest-nodeauth": "0.9.2",
"colors": "^1.3.3"
},
"devDependencies": {
"@azure/ms-rest-nodeauth": "0.9.2",
"colors": "^1.3.3",
"@types/node": "^10.12.18",
"standard-version": "^4.4.0"
},
Expand Down
8 changes: 4 additions & 4 deletions core/src/deployment-context.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { IBakePackage, IBakeRegion, IBakeConfig, IBakeEnvironment } from "./bake-interfaces";
import { Logger } from "./logger";
import { TokenCredentialsBase } from "@azure/ms-rest-nodeauth";
import { ApplicationTokenCredentials } from "@azure/ms-rest-nodeauth";
import { IIngredient } from ".";

export class DeploymentContext {
constructor(auth: TokenCredentialsBase, bake : IBakePackage,
constructor(auth: ApplicationTokenCredentials, bake : IBakePackage,
region: IBakeRegion, logger: Logger, ingredient: IIngredient = <IIngredient>{}) {

this._package = bake
Expand All @@ -18,7 +18,7 @@ export class DeploymentContext {
_ingredient: IIngredient
_region: IBakeRegion
_logger: Logger
_auth: TokenCredentialsBase
_auth: ApplicationTokenCredentials

public get Config() : IBakeConfig {
return this._package.Config
Expand All @@ -39,7 +39,7 @@ export class DeploymentContext {
return this._logger
}

public get AuthToken(): TokenCredentialsBase {
public get AuthToken(): ApplicationTokenCredentials {
return this._auth
}

Expand Down
9 changes: 3 additions & 6 deletions ingredient-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@
},
"peerDependencies": {
"@azbake/core": "0.*",
"@azure/ms-rest-nodeauth": "0.*"
"@azure/ms-rest-nodeauth": "0.9.2"
},
"devDependencies": {
"@types/node": "^10.12.18"
},
"dependencies": {
"@azbake/core": "^0.1.21",
"@azure/ms-rest-nodeauth": "^0.9.1"
"@types/node": "^10.12.18",
"@azure/ms-rest-nodeauth": "0.9.2"
}
}
4 changes: 2 additions & 2 deletions ingredient/ingredient-app-insights/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
},
"peerDependencies": {
"@azbake/core": "0.*",
"@azure/ms-rest-nodeauth": "0.*"
"@azure/ms-rest-nodeauth": "0.9.2"
},
"devDependencies": {
"@azbake/core": "^0.1.30",
"@azure/ms-rest-nodeauth": "0.*",
"@azure/ms-rest-nodeauth": "0.9.2",
"@types/node": "^10.12.18"
},
"dependencies": {
Expand Down
Loading

0 comments on commit eca4e13

Please sign in to comment.