Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

houdini does not work with current sveltkit version ($app/env has been renamed to $app/environment) #515

Closed
nhe23 opened this issue Sep 6, 2022 · 1 comment

Comments

@nhe23
Copy link

nhe23 commented Sep 6, 2022

Describe the bug

In recent sveltekit changes $app/env has been renamed to $app/environment. Houdini however generates code with references to '$app/env' which breaks the sveltekit app.

Severity

blocking an upgrade

Steps to Reproduce the Bug

  1. Use houdini in sveltekit project with the newest version

Expected behavior

I expect houdini to work with sveltekit

System Info

System:
    OS: macOS 12.5.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 74.70 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.4.0 - ~/.volta/tools/image/node/18.4.0/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 8.12.1 - ~/.volta/tools/image/node/18.4.0/bin/npm
  Browsers:
    Brave Browser: 103.1.41.96
    Chrome: 105.0.5195.102
    Firefox: 104.0
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.88 => 1.0.0-next.88 
    @sveltejs/kit: 1.0.0-next.471 => 1.0.0-next.471 
    houdini: 0.15.9 => 0.15.9 
    svelte: ^3.44.0 => 3.48.0 
    vite: 3.1.0 => 3.1.0

Reproduction

No response

Additional context

No response

@nhe23
Copy link
Author

nhe23 commented Sep 6, 2022

Just found out that this has been already fixed, if you use the 'next' version of houdini.

@nhe23 nhe23 closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant