Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link landing page examples to real entities #544

Closed
carlgieringer opened this issue Aug 25, 2023 · 2 comments
Closed

Link landing page examples to real entities #544

carlgieringer opened this issue Aug 25, 2023 · 2 comments
Labels
growth Helping users discover Howjdu. ux Improving user experience
Milestone

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Aug 25, 2023

This will reward exploring the examples rather than the bad experience of 'not found'.

This issue is a little complicated, because basically we would need to tie the code to the data. E.g. we aren't guaranteed to have those specific propositions and justifications in any particular env, and even if we do, they may have different IDs.

Some potential steps:

  1. Right now the API returns an UNEXPECTED_ERROR, probably because it doesn't recognize the string "example" as a valid ID. We should fix that to return a NOT_FOUND.
  2. We could add a few special boolean columns to the entities used on the landing page to indicate that they are those special entities for use on the landing page. is_landing_page_root_proposition. Or it could be an array column containing all the roles the entity holds: app_roles: ["LANDING_PAGE_ROOT_PROPOSITION"]. That would allow the same entity to satisfy multiple roles in different places, including in our docs.howdju.com page.

Also convert the WritQuotes to MediaExcerpts (#201).

@carlgieringer carlgieringer added growth Helping users discover Howjdu. ux Improving user experience labels Aug 25, 2023
@carlgieringer carlgieringer self-assigned this Aug 25, 2023
@carlgieringer carlgieringer added this to the P0 milestone Sep 5, 2023
@carlgieringer
Copy link
Contributor Author

Also a fast short-term fix is just to hard-code the prod IDs. It won't work locally or in preprod, but at least the prod deployment will have a good experience.

@carlgieringer
Copy link
Contributor Author

Unassigning myself because the workaround in #635 is sufficient for now.

@carlgieringer carlgieringer removed their assignment Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
growth Helping users discover Howjdu. ux Improving user experience
Projects
None yet
Development

No branches or pull requests

1 participant