From 14d4cc4e51e79d6cdabe715feee0fe908804ee3c Mon Sep 17 00:00:00 2001
From: Stephen Salinas <ssalinas@hubspot.com>
Date: Wed, 22 Feb 2017 12:18:41 -0500
Subject: [PATCH 1/2] ability to specify params on request history in client

---
 .../singularity/client/SingularityClient.java      | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java b/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
index 613a0317d1..de398549f7 100644
--- a/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
+++ b/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
@@ -936,11 +936,23 @@ public Collection<SingularityTaskIdHistory> getActiveTaskHistoryForRequest(Strin
   }
 
   public Collection<SingularityTaskIdHistory> getInactiveTaskHistoryForRequest(String requestId) {
+    return getInactiveTaskHistoryForRequest(requestId, 10, 1);
+  }
+
+  public Collection<SingularityTaskIdHistory> getInactiveTaskHistoryForRequest(String requestId, int count, int page) {
+    return getInactiveTaskHistoryForRequest(requestId, count, page, Optional.<String>absent(), Optional.<String>absent(), Optional.<ExtendedTaskState>absent(), Optional.<Long>absent(), Optional.<Long>absent(), Optional.<Long>absent(), Optional.<Long>absent(), Optional.<OrderDirection>absent());
+  }
+
+  public Collection<SingularityTaskIdHistory> getInactiveTaskHistoryForRequest(String requestId, int count, int page, Optional<String> host, Optional<String> runId,
+    Optional<ExtendedTaskState> lastTaskStatus, Optional<Long> startedBefore, Optional<Long> startedAfter, Optional<Long> updatedBefore, Optional<Long> updatedAfter,
+    Optional<OrderDirection> orderDirection) {
     final String requestUri = String.format(REQUEST_INACTIVE_TASKS_HISTORY_FORMAT, getHost(), contextPath, requestId);
 
     final String type = String.format("inactive (failed, killed, lost) task history for request %s", requestId);
 
-    return getCollection(requestUri, type, TASKID_HISTORY_COLLECTION);
+    Map<String, Object> params = taskSearchParams(Optional.of(requestId), Optional.<String>absent(), runId, host, lastTaskStatus, startedBefore, startedAfter, updatedBefore, updatedAfter, orderDirection, count, page);
+
+    return getCollectionWithParams(requestUri, type, Optional.of(params), TASKID_HISTORY_COLLECTION);
   }
 
   public Optional<SingularityDeployHistory> getHistoryForRequestDeploy(String requestId, String deployId) {

From 817b3645fb03bcec5575461e09236589e1b0e46a Mon Sep 17 00:00:00 2001
From: Stephen <ssalinas@users.noreply.github.com>
Date: Mon, 27 Feb 2017 08:47:04 -0500
Subject: [PATCH 2/2] Keep the default at 100

---
 .../java/com/hubspot/singularity/client/SingularityClient.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java b/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
index de398549f7..06f2d0240b 100644
--- a/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
+++ b/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
@@ -936,7 +936,7 @@ public Collection<SingularityTaskIdHistory> getActiveTaskHistoryForRequest(Strin
   }
 
   public Collection<SingularityTaskIdHistory> getInactiveTaskHistoryForRequest(String requestId) {
-    return getInactiveTaskHistoryForRequest(requestId, 10, 1);
+    return getInactiveTaskHistoryForRequest(requestId, 100, 1);
   }
 
   public Collection<SingularityTaskIdHistory> getInactiveTaskHistoryForRequest(String requestId, int count, int page) {