Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task history ui updates for sort #2003

Merged
merged 8 commits into from
Sep 5, 2019
Merged

Task history ui updates for sort #2003

merged 8 commits into from
Sep 5, 2019

Conversation

ssalinas
Copy link
Member

  • Make the backend sort correctly when combining zk + sql data. Most times this is already sorted correctly, but other times it is not, depending on history persister times
  • Make the sort more obvious (but still not currently editable) in the UI

@ssalinas
Copy link
Member Author

Realized after looking further that a bunch of our code sorts by updatedAt or assumes it is sorted as such. But the sql and default query args sort by startedAt. Fixing that so everything is consistent on updatedAt

@sjeropkipruto
Copy link
Contributor

🚢

@ssalinas ssalinas added this to the 1.1.0 milestone Sep 5, 2019
@ssalinas ssalinas merged commit 025fa3d into master Sep 5, 2019
@ssalinas ssalinas deleted the task_history_ui_updates branch September 5, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ssalinas @sjeropkipruto