move webhook processing to leader only #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also move locks into constructor rather than protected, non-final access - change enabled / abort to use methods
| } | ||
|
|
||
| protected SingularityLeaderOnlyPoller(long pollDelay, TimeUnit pollTimeUnit, boolean enabled) { | ||
| protected SingularityLeaderOnlyPoller(long pollDelay, TimeUnit pollTimeUnit, Optional<Lock> lockHolder) { |
There was a problem hiding this comment.
That constructor will only ever be called if a lock is present. Make it take the lock directly and have it wrap in an optional here. Also, add a checkNotNull(). :-)
This avoids people to cut'n'paste your code and then replacing the super with super (... , Optional.<Lock>absent())
There was a problem hiding this comment.
So in that case I would need a third private constructor which takes the optional?
Maybe it's worth just having a single constructor that takes the optional and making everyone call it.
tpetr
added a commit
that referenced
this pull request
Jan 13, 2015
move webhook processing to leader only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access