Allow user to functions in the same directory #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcorne
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Makes sense to me as a first step. We had also talked about adjusting hs create function to work in a similar fashion to the create flow in the Design Manager where we adjust the prompt based on the context so that a user can create additional function in the same .function folder.
|
Makes sense. Revisiting #179, I swear that referenced the bug that this addresses but I can't find any issues that reference that now. I'll keep that issue open for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for ancestral
*.functiondirectories (which wasn't working) this switches to looking forserverless.jsonconfig files@gcorne I see that you assigned that issue to yourself, if you have another idea for this in mind let me know