Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport is resized when sidebar is open and pause menu is opened #3524

Closed
robertlong opened this issue Dec 9, 2020 · 5 comments · Fixed by #3533
Closed

Viewport is resized when sidebar is open and pause menu is opened #3524

robertlong opened this issue Dec 9, 2020 · 5 comments · Fixed by #3533
Assignees
Labels
bug P1 Address as quickly as possible [QA]:Verified-fixed Label for QA to mark verified fixed issues redesign Issues related to the room UI redesign

Comments

@robertlong
Copy link
Contributor

Description
This bug was reported by @robinkwilson

To Reproduce

  1. Open the chat sidebar
  2. Open pause menu
  3. The canvas viewport shrinks

Expected behavior
The canvas should always be resized to the size of the viewport

@robertlong robertlong added bug needs triage For bugs that have not yet been assigned a fix priority P1 Address as quickly as possible redesign Issues related to the room UI redesign and removed needs triage For bugs that have not yet been assigned a fix priority labels Dec 9, 2020
@robertlong robertlong linked a pull request Dec 11, 2020 that will close this issue
@brianpeiris
Copy link
Contributor

Probably the same bug, but I also see this happen when the sidebar is closed.

@brianpeiris
Copy link
Contributor

To add more detail, I see this happen in Firefox on Windows. If I resize my browser window, the rendered viewport squeezes horizontally, and then when I press the spacebar, it stretches back horizontally.

@Softvision-GeluHaiduc
Copy link
Contributor

I verified this issue using Firefox and Chrome on Windows 10 and Ubuntu 20.04.1
The main issue reported is fixed but unfortunately, the scenario depicted by Brian in the above comment is still reproducible on Chrome on both Windows and Ubuntu, the issue is not reproducible on Firefox.
Here is a video of the issue.

@robertlong
Copy link
Contributor Author

@Softvision-GeluHaiduc I think this should be fixed in all browsers now

@Softvision-GeluHaiduc
Copy link
Contributor

I have verified this issue using Firefox and Chrome on Windows 10 and Ubuntu 20.04.1
Now, the viewport is not resized when the sidebar is open and the pause menu is opened, the scenario from Brian's comment is also fixed.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added [QA]:Verified-fixed Label for QA to mark verified fixed issues and removed [QA]:Needs-Verification labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 Address as quickly as possible [QA]:Verified-fixed Label for QA to mark verified fixed issues redesign Issues related to the room UI redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants