Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glTF extension support for Open Brush shaders #5738

Open
madjin opened this issue Oct 6, 2022 · 1 comment
Open

Add glTF extension support for Open Brush shaders #5738

madjin opened this issue Oct 6, 2022 · 1 comment
Labels
enhancement work that enhances an existing feature

Comments

@madjin
Copy link

madjin commented Oct 6, 2022

Is your feature request related to a problem? Please describe.
Open Brush glb files don't look right in Hubs, this is the sample file I tested and how the glb looks in hubs
https://github.com/madjin/openbrush_tests/blob/main/all_brushes.glb
image

This is how it should look:
openbrush

Describe the solution you'd like
Here's the glTF extension with sample code on how to implement: https://github.com/icosa-gallery/three-icosa

image

It seems that gltfLoader is in this part of the project: https://github.com/mozilla/hubs/blob/master/src/components/gltf-model-plus.js

Describe alternatives you've considered
Not sure, I just really want our drawings to work in Hubs so we can have meetings with them and draw particles in places more easily

Additional context
There is also a $450 bounty for whomever can solve this issue btw

@madjin madjin added the enhancement work that enhances an existing feature label Oct 6, 2022
@andybak
Copy link

andybak commented Sep 27, 2023

Can something be done to move this forward? The Open Brush team is very interested in supporting this. If we could get someone to work on it, would a PR be likely to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants