Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitECS: Links don't work if included in a GLTF file #6201

Closed
keianhzo opened this issue Aug 9, 2023 · 2 comments · Fixed by #6229
Closed

bitECS: Links don't work if included in a GLTF file #6201

keianhzo opened this issue Aug 9, 2023 · 2 comments · Fixed by #6229
Labels
bug needs triage For bugs that have not yet been assigned a fix priority new-loader P1 Address as quickly as possible
Milestone
New Loader Release

Comments

@keianhzo
Copy link
Contributor

keianhzo commented Aug 9, 2023

Description
Links are correctly rendered when the are spawned using loadHtml as part of the media-loading system but we are not correctly handling it if the link component is attached to an object in a GLTF file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a scene with an empty that has a link component in Blender/Spoke or drag and drop a GLTF with a link component in a scene.

Expected behavior
The link surface with the preview and the link menu should be rendered
@keianhzo keianhzo added bug needs triage For bugs that have not yet been assigned a fix priority labels Aug 9, 2023
@keianhzo keianhzo added this to the New Loader Release milestone Aug 9, 2023
@keianhzo keianhzo mentioned this issue Aug 9, 2023
Merged
@takahirox takahirox changed the title Links don't work if included in a GLTF file bitECS: Links don't work if included in a GLTF file Aug 9, 2023
@johnshaughnessy johnshaughnessy added the P1 Address as quickly as possible label Aug 17, 2023
@takahirox
Copy link
Contributor

@keianhzo Do you have an example glTF asset that the problem can be reproduced with?

@keianhzo
Copy link
Contributor Author

This should trigger it. It's a link pointing to the mozilla website.
link.glb.zip

@takahirox takahirox mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage For bugs that have not yet been assigned a fix priority new-loader P1 Address as quickly as possible
Projects
None yet
Milestone
New Loader Release
Development

Successfully merging a pull request may close this issue.

bitECS: Support glTF link component Hubs-Foundation/hubs
3 participants
@keianhzo @johnshaughnessy @takahirox