Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author formatting in tailwind publications #3112

Closed
2 tasks done
djps opened this issue Jun 18, 2024 · 2 comments
Closed
2 tasks done

Author formatting in tailwind publications #3112

djps opened this issue Jun 18, 2024 · 2 comments

Comments

@djps
Copy link

djps commented Jun 18, 2024

Preliminary Checks

Description

The formatting of the authors in a publication page in tailwind has a space between the author and the comma and there is no comma separating an author with a photo and those without photos.

Reproduction Link

https://github.com/HugoBlox/hugo-blox-builder

Steps to Reproduce

  1. Build site

Expected Result

Author, Photo New Author, Last Author

Actual Result

Author Photo New Author , Last Author

What Hugo Module versions does your site use?

module github.com/HugoBlox/theme-documentation

go 1.19

require (
github.com/HugoBlox/hugo-blox-builder/modules/blox-plugin-netlify v1.1.2-0.20231209203044-d31adfedd40b
github.com/HugoBlox/hugo-blox-builder/modules/blox-tailwind v0.2.1-0.20240602133901-492e343c2a33
github.com/HugoBlox/hugo-blox-builder/modules/blox-plugin-reveal v1.1.2
)

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

Which Hugo Blox template are you using?

documentation

What version of Hugo are you using?

Hugo version: 0.127.0

@gcushen
Copy link
Collaborator

gcushen commented Jul 13, 2024

It was intended to have no comma between two avatar photos, as it can be redundant and become unnecessarily verbose, pushing the article metadata onto multiple lines in the case of a few authors.

The downside, as in your use case, is that if some users have avatars uploaded and others don't then the comma separation may appear inconsistent.

The optimal solution for multiple authors might be just to stack all the author avatars at the start (similar to how other popular websites address multiple authors) and then follow that with a list of authors separated by commas...

Copy link

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants